Implement support for networking-as-a-service (aka OpenStack Neutron) #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -244,6 +244,28 @@ protected function getAlias($key) | |||
| return $key; | |||
| } | |||
|
|
|||
| protected function recursivelyAliasPropertyValue($propertyValue) | |||
There was a problem hiding this comment.
No header comment for this function?
There was a problem hiding this comment.
Doesn't the super long name say it all? 😃
Just kidding, of course. I'll add the header comment.
|
👍 this is looking really good. Apart from those minor issues LGTM |
|
Thank you @jamiehannaford and @gecampbell for your review. Changes and documentation (README.md + USERGUIDE.md) coming today. |
ycombinator
changed the title
|
@gecampbell, @jamiehannaford: I've made the changes you suggested earlier today + added the quickstart and complete user guide. I'd appreciate a final review from one or both of you, followed by a merge if all looks good to you. Thank you. |
jamiehannaford
pushed a commit
that referenced
this pull request
Nov 7, 2014
Implement support for networking-as-a-service (aka OpenStack Neutron)
|
Awesome work 🚢 it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.