Neutron Security Groups + Security Group Rules #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ycombinator
commented
Mar 5, 2015
ycombinator
commented
- Unit tests
- Implementation
- User guide
- Downloadable code samples
- Smoke tests
…curity Group Rules.
|
@jamiehannaford This PR is ready for review. Thanks! |
| /** | ||
| * Creates a new SecurityGroupRule and returns it. | ||
| * | ||
| * @param array $params SecurityGroupRule creation parameters. @see https://github.com/rackspace/php-opencloud/blob/master/docs/userguide/Networking/USERGUIDE.md#create-a-security-group-rule |
There was a problem hiding this comment.
nit: @see should be on separate line
| following example: | ||
|
|
||
| ```php | ||
| $securityGroup = $networkingService->getSecurityGroup('2076db17-a522-4506-91de-c6dd8e837028'); |
There was a problem hiding this comment.
nit: {securityGroupId}
There was a problem hiding this comment.
I checked the other User Guides and they are using literals instead of placeholders for IDs. So, for consistency sake, I will leave this as-is.
jamiehannaford
pushed a commit
that referenced
this pull request
Mar 6, 2015
[WIP] Neutron Security Groups + Security Group Rules
ycombinator
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.