Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No ID listed in warnings #86

Closed
AsaAyers opened this issue Jul 30, 2015 · 8 comments
Closed

No ID listed in warnings #86

AsaAyers opened this issue Jul 30, 2015 · 8 comments

Comments

@AsaAyers
Copy link
Contributor

I added the ID back in #14 so we could actually find the elements producing warnings.

selection_195

What's the point of warning without a direct reference to where it's being produced?

Putting the ID only on elements that were failing was great because I had some CSS targeting *[id^=a11y-] { which would cause broken elements to fade in and out so you could find them. The animation is also very irritating which motivates fixing it immediately.

So now after upgrading I can't find the elements throwing warnings and I can't style broken elements.

@blairanderson
Copy link

you should activate this option a11y(React, { includeSrcNode: true });

@joeybaker
Copy link

@blairanderson what does that option do? It doesn't seem to be documented?

@AsaAyers
Copy link
Contributor Author

I belive I did. That's why this is prefixed with Pushmenu, but that doesn't actually help me find the element, just the Component.

I ran into enough problems trying to upgrade it made more sense to just give up and go back to my old fork of the project.

@joeybaker
Copy link

@AsaAyers are you maintaining your fork? This repo hasn't gotten much love :\

@AsaAyers
Copy link
Contributor Author

No, I had to create a fork when I had a bunch of PRs here that weren't merged. They have been merged, but everything I've done has been changed. What I can say is that my fork works for my project and this version doesn't any more. It was more work than I'm willing to do to change that.

@joeybaker
Copy link

Got it, thanks.

@blairanderson
Copy link

@joeybaker It shows the offending HTML element...

screen shot 2015-09-01 at 12 53 20 am

its documented on the README:

If you want to log DOM element references for easy lookups in the DOM inspector, use the includeSrcNode option. a11y(React, { includeSrcNode: true });

@erin-doyle
Copy link
Collaborator

I believe this has been answered and the reporting has changed since this was posted. I'm going to close this now but please feel free to re-open if you're still having issues with the latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants