Deprecate `between` method for ActiveRecord #33

Merged
merged 1 commit into from Jan 15, 2014

Conversation

Projects
None yet
2 participants
Collaborator

johnnyshields commented Jan 14, 2014

I propose to deprecate between method for ActiveRecord, as it is set in the global ActiveRecord::Model scope and is likely to conflict with other gems. It is replaced with between_times

I've already removed between for Mongoid in a previous commit, since it conflicts with a native Mongoid method.

@radar please confirm.

@johnnyshields johnnyshields Deprecate `between` method for ActiveRecord, as it is set in the glob…
…al ActiveRecord::Model scope and is likely to conflict with other gems.
bc8244c
Owner

radar commented Jan 14, 2014

👍 Looks good to me.

johnnyshields merged commit dd65a41 into master Jan 15, 2014

1 check passed

default The Travis CI build passed
Details

johnnyshields deleted the dep-between branch May 5, 2015

johnnyshields restored the dep-between branch May 5, 2015

johnnyshields deleted the dep-between branch May 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment