-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement afl= and afb= #13596
Comments
see libr/core/cmd_open.c. 186 for inspiration it will be good to implement a generic api to do this ascii bars output, so we dont hahve to reimplement the renderer for each data. |
I'll start working on this. If no one is already working. |
will you do the refactoring?
… On 2 Apr 2019, at 11:02, Deepak Chethan ***@***.***> wrote:
I'll start working on it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#13596 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA3-lowofWfIExx74DD2FgiMBXIYYXcPks5vcxyrgaJpZM4cUnsy>.
|
Yes, I will. It might take a bit of time since I have to go through the code first. |
i can give you some pointers if you need, let me know how it goes |
Yes, I am stuck. The due to different list types (SdbList and RList) I am not able to figure out how to use same method for both. |
you can convert one list into another for now, but we should unify all the code to only use the impl in sdb because that cant be removed, the one in r2 was the one defiining the design for it. but we should avoid dupes in apis.
i did the same thing in my zdiff commit because i have the zignatures in sdblist, because its a SdbKv storage.. but then ii need to use the r_list methods, so iim doinig sdb_foreach_list() to get the SdbList and then i create the RList storage to work with, dont worry about simplifying this now, we should define a plan for refactoring this out later
@ret2libc ^
… On 5 Apr 2019, at 18:03, Deepak Chethan ***@***.***> wrote:
i can give you some pointers if you need, let me know how it goes
Yes, I am stuck. The due to different list types (SdbList and RList) I am not able to figure out how to use same method for both.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#13596 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA3-luIf0eeGMe5rgnpghznPSZHalT_nks5vd3PmgaJpZM4cUnsy>.
|
List list functions and bbs of a function using the ascii art bars like om= does
The text was updated successfully, but these errors were encountered: