Hang in aac

[Maijin]

Via @Zurich1994

Work environment

Questions	Answers
OS/arch/bits (mandatory)	OSX/linux
File format of the file you reverse (mandatory)	PE
Architecture/bits of the file (mandatory)	x86/32
r2 -v full output, not truncated (mandatory)	radare2 3.8.0 23022 @ darwin-x86-64 git.3.8.0-40-g2ad9a6bdc / commit: 2ad9a6b build: 2019-09-10__09:46:30

Expected behavior

Analysis goes on. (864K binary)

Actual behavior

Analysis stall.

Steps to reproduce the behavior

• Please share the binary if it is shareable by drag and dropping it here in a zip archive 32c5ab8d02636e2316fa6fc04d492a8678f00d628ae7544a634ff8956727ff5c.zip

[GustavoLCR]

Isn't this the same as #14782 ?

[Zurich1994]

Isn't this the same as #14782 ?

But this problem still there even in the newest version~

[radare]

Because my fix havent been merged yet

…

On 11 Sep 2019, at 04:17, Huanran.Wang ***@***.***> wrote: Isn't this the same as #14782 ? But this problem still there even in the newest version~ — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[radare]

its merged and fixed. enjoy :) now it takes ~8s in my laptop

[radare]

will be good to have a smaller binary to put in the testsuite

[Maijin]

@radare Actually this one is not fixed, I just tried on master, both aa and aac are still hanging.

[radare]

Can you try setting anal.nonull=8 and run aa again and ser if it hangs? Also, using anal.verbose sometimes is helpful

…

On 15 Sep 2019, at 12:58, Maijin ***@***.***> wrote: Reopened #15004. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[Maijin]

same with the nonull. (interestingly and unrelated likely, stopping aa then relaunching it make it finishes instantly.)

[radare]

ooook i found the root cause oft he problem and it basically requires a full rewrite of the whole fcn storage because the rbtree implementation is unmaintainable and buggy. i did a workaround in a PR that should make this work. and in this binary it turns from infinite time to 1.8s, so it seems like its improving the analysis somehow. i plan to rewrite all that stuff during the 4.x releases

[radare]

I pushed a workaround to solve this issue in here: bb810cf

just use r2 -e anal.norevisit=true

maybe we should rename this to anal.visitonce, but well, its just a hack at the end, but this binary exposes some other issues in the analysis when the binary is obfuscated. so its a good testcase for improving the analysis. ill keep the issue open and try to fix more things in further releases