Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: color ascii escapes in json output #10898

Merged
merged 1 commit into from Aug 3, 2018

Conversation

@cyanpencil
Copy link
Contributor

@cyanpencil cyanpencil commented Aug 2, 2018

Color in comments created some problems in cutter:

photo_2018-08-02_12-25-23

Reported by @fcasal (thanks!)

This does not fix 100% of the cases, but 99% of them. (e.g. some ascii escapes will still be seen if a user sets a special vartype comment with Ct containing UTF8 chars in it, but that's pretty rare, and required more major changes, if needed I'll do it in another pr)

@ret2libc
Copy link
Contributor

@ret2libc ret2libc commented Aug 2, 2018

Is the image taken from before or after the change?

@cyanpencil
Copy link
Contributor Author

@cyanpencil cyanpencil commented Aug 2, 2018

Is the image taken from before or after the change?

Haha, right I should have specified. It is an image of the bug, taken before the changes.

@ret2libc
Copy link
Contributor

@ret2libc ret2libc commented Aug 2, 2018

How is that after the PR?

@cyanpencil
Copy link
Contributor Author

@cyanpencil cyanpencil commented Aug 2, 2018

image

Different colors because the first screen was sent to me by @fcasal

@ret2libc
Copy link
Contributor

@ret2libc ret2libc commented Aug 2, 2018

Oh wow, much better :)

@radare
Copy link
Collaborator

@radare radare commented Aug 2, 2018

@XVilka
Copy link
Contributor

@XVilka XVilka commented Aug 3, 2018

@radare agree, a good idea.

@XVilka XVilka merged commit 1c55911 into radareorg:master Aug 3, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants