Fix: color ascii escapes in json output #10898
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Color in comments created some problems in cutter:
Reported by @fcasal (thanks!)
This does not fix 100% of the cases, but 99% of them. (e.g. some ascii escapes will still be seen if a user sets a special vartype comment with
Ct
containing UTF8 chars in it, but that's pretty rare, and required more major changes, if needed I'll do it in another pr)