Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meson: Change completions installation directory #13647

Merged
merged 1 commit into from
Apr 7, 2019

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Apr 6, 2019

To be able to use completion with zsh, completion script must be in
the fpath variable. On Ubuntu, these paths are:

% print -ln $fpath
/usr/local/share/zsh/site-functions
/usr/share/zsh/vendor-functions
/usr/share/zsh/vendor-completions
/usr/share/zsh/functions/Calendar
/usr/share/zsh/functions/Chpwd
/usr/share/zsh/functions/<.. redacted ..>                               

On Arch Linux, these paths are:

% print -ln $fpath
/usr/local/share/zsh/site-functions
/usr/share/zsh/site-functions
/usr/share/zsh/functions/Calendar
/usr/share/zsh/functions/Chpwd
/usr/share/zsh/functions/<.. redacted ..>              

So if r2 users install radare2 with prefix=/usr/local, completion will not work
on both Ubuntu and Arch Linux. In this case, users have to edit fpath or link them to
/usr/local/share/zsh/site-functions. In case of users install radare2 with prefix=/usr,
completion will work on Arch Linux.

With this PR, users on both distro could use completion when installing with
prefix=/usr/local. However, Ubuntu users might need to manually edit
fpath themselves.

@radare radare merged commit 9c659fd into radareorg:master Apr 7, 2019
@tesuji tesuji deleted the zsh-install branch April 7, 2019 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants