Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Fix Post-indexed memory access for ARM #15298

Merged
merged 2 commits into from
Oct 20, 2019
Merged

WIP: Fix Post-indexed memory access for ARM #15298

merged 2 commits into from
Oct 20, 2019

Conversation

qwuau06
Copy link
Contributor

@qwuau06 qwuau06 commented Oct 17, 2019

fixed #15295 str part for ARM32. Post-indexed store fixed.

@radare
Copy link
Collaborator

radare commented Oct 17, 2019

Screenshot 2019-10-17 at 18 14 47

@qwuau06
Copy link
Contributor Author

qwuau06 commented Oct 17, 2019 •
edited
Loading

Screenshot 2019-10-17 at 18 14 47

isn't the expected result of str r2, [r3], 5 supposed to be storing value of r2 into [r3] and increase r3 by 5 afterwards? The test now is essentially the same as str r2, [r3, 5]! case.
Screenshot_2019-10-17_18-21-02
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0552a/BABJGHFJ.html

@qwuau06 qwuau06 changed the title fixed #15295 str part for ARM32 WIP:fixing #15295 Oct 18, 2019
@qwuau06 qwuau06 changed the title WIP:fixing #15295 WIP: fixing #15295 Oct 18, 2019
@qwuau06 qwuau06 changed the title WIP: fixing #15295 WIP: Fixing Post-indexed memory access for ARM Oct 18, 2019
@qwuau06 qwuau06 changed the title WIP: Fixing Post-indexed memory access for ARM WIP: Fix Post-indexed memory access for ARM Oct 18, 2019
@qwuau06
Copy link
Contributor Author

qwuau06 commented Oct 19, 2019

https://github.com/radareorg/radare2-regressions/pull/1989
r2r test case pr, targeting the same problem. it should now pass the test.

@radare
Copy link
Collaborator

radare commented Oct 20, 2019

please rebase when master gets green

@thestr4ng3r
Copy link
Contributor

rebased

@thestr4ng3r
Copy link
Contributor

@qwuau06 Is the behavior correct now?

@qwuau06
Copy link
Contributor Author

qwuau06 commented Oct 20, 2019

@qwuau06 Is the behavior correct now?

Screenshot_2019-10-20_16-28-18
I think it is now.

@qwuau06
Copy link
Contributor Author

qwuau06 commented Oct 20, 2019

please rebase when master gets green

just rebased

@qwuau06
Copy link
Contributor Author

qwuau06 commented Oct 20, 2019

@qwuau06 Is the behavior correct now?

Only str is correct now. Haven't touched ldr yet. it seems the code for ldr is a bit unorganized.

@radare radare merged commit dc39e93 into radareorg:master Oct 20, 2019
@radare
Copy link
Collaborator

radare commented Oct 20, 2019

let's merge the str part, open a new pr for the ldr. Thanks!

@qwuau06 qwuau06 mentioned this pull request Oct 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wrong ESIL parsing of ldr/str with post-indexed offset
3 participants
@qwuau06 @radare @thestr4ng3r