Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check version for pkgname correctly #15860

Merged
merged 1 commit into from Jan 20, 2020
Merged

Check version for pkgname correctly #15860

merged 1 commit into from Jan 20, 2020

Conversation

thestr4ng3r
Copy link
Contributor

  • dot can be null
  • Using R2_VERSION_MAJOR/MINOR is wrong because they will be continuously updated and we want to check for exactly 4.2.0
  • The version check logic itself was wrong

@thestr4ng3r
Check version for pkgname correctly
0da5e2a 
dot can be null
Using R2_VERSION_MAJOR/MINOR is wrong because they will be continuously updated and we want to check for exactly 4.2.0
The version check logic itself was wrong
@radare radare merged commit c01a491 into master Jan 20, 2020
@radare
Copy link
Collaborator

radare commented Jan 20, 2020

thanks, i need more sleep

@thestr4ng3r thestr4ng3r deleted the pkgname-correct branch January 20, 2020 12:37
@lgtm-com
Copy link

lgtm-com bot commented Jan 20, 2020

This pull request introduces 1 alert when merging 0da5e2a into 066c127 - view on LGTM.com

new alerts:

  • 1 for Comparison result is always the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.2.0 (Arctic World Archive)
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thestr4ng3r @radare