Add pyc plugin #16771

FXTi · 2020-05-05T14:40:27Z

Detailed description

Move RBin, RAsm & RAnal plugins for python bytecode from https://github.com/radareorg/radare2-extras

Fix .arch field pass in RBin
Fix all warnings in compilation
Fix header path issue in libr/anal/p/anal_rsp.c

Test plan

test pass

Closing issues

radareorg/radare2-extras#244

radare · 2020-05-05T16:46:59Z

do not use unnecssary preincrements

lgtm-com · 2020-05-05T17:59:53Z

This pull request introduces 5 alerts when merging e0fc42464f070c12623105e076c59736138541c7 into e9152db - view on LGTM.com

new alerts:

4 for Comparison result is always the same
1 for FIXME comment

lgtm-com · 2020-05-05T19:15:08Z

This pull request introduces 5 alerts when merging ba4e685af6a9a5de7c2fff8f3df0217a965ebc58 into e9152db - view on LGTM.com

new alerts:

4 for Comparison result is always the same
1 for FIXME comment

radare

The bignum impl should be generic and live in r_util. Use size_t for loop variables. Add some tests

libr/anal/p/anal_pyc.c

libr/asm/arch/pyc/opcode.c

libr/bin/format/pyc/bn.h

libr/asm/p/asm_pyc.c

libr/bin/format/pyc/bn.c

libr/bin/format/pyc/marshal.c

XVilka · 2020-05-06T01:26:13Z

Regarding the bignum in r_util - it was discussed long time ago for supporting long registers such as SSE, AVX, etc: https://github.com/radareorg/radare2/issues/6093#issuecomment-312997305
Did time has come?

lgtm-com · 2020-05-06T05:56:51Z

This pull request introduces 5 alerts when merging 22bdd557276ba4c16896b74b0935c26c1a49a47b into 4fa630c - view on LGTM.com

new alerts:

4 for Comparison result is always the same
1 for FIXME comment

lgtm-com · 2020-05-06T09:17:59Z

This pull request introduces 5 alerts when merging 52c59159f1035309642291418d93b6c8750e63de into 64e6df5 - view on LGTM.com

new alerts:

4 for Comparison result is always the same
1 for FIXME comment

lgtm-com · 2020-05-06T20:37:06Z

This pull request introduces 5 alerts when merging 19dfafd753925f5ba9401177fd8f4590f2f56276 into 03a5c4d - view on LGTM.com

new alerts:

4 for Comparison result is always the same
1 for FIXME comment

xarkes · 2020-05-07T06:26:33Z

As it's been said above, it would be great if you could add some unit tests for libr/util/big.c :)

FXTi · 2020-05-07T07:37:50Z

@xarkes It's still working in progress. I will mention Ready in commits when it's ready.

radare · 2020-05-07T19:58:53Z

Then i would suggest to use R_IPI

…

On 6 May 2020, at 06:38, FXTi ***@***.***> wrote: @FXTi commented on this pull request. In libr/asm/arch/pyc/opcode.c: > + { "v3.8.0a2", opcode_38 }, + { "v3.8.0a3", opcode_38 }, + { "v3.8.0a4", opcode_38 }, + { "v3.8.0b1", opcode_38 }, + { "v3.8.0b2", opcode_38 }, + { "v3.8.0b3", opcode_38 }, + { "v3.8.0b4", opcode_38 }, + { "v3.8.0rc1", opcode_38 }, + { "v3.8.1", opcode_38 }, + { "v3.8.1rc1", opcode_38 }, + { "v3.9.0a1", opcode_39 }, + { "v3.9.0a2", opcode_39 }, + { "v3.9.0a3", opcode_39 }, +}; + +bool pyc_opcodes_equal (pyc_opcodes *op, const char *version) { No, it will be used outside the file — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

lgtm-com · 2020-05-07T20:29:42Z

This pull request introduces 8 alerts when merging 379b51c80c6f0a57f5fe70e24c54ac0c00b1deb5 into 4700810 - view on LGTM.com

new alerts:

4 for Comparison result is always the same
2 for Unsigned comparison to zero
2 for FIXME comment

XVilka · 2020-05-08T03:41:35Z

By the way, in the future I recommend to squash this PR in two commits - one adding the new bignum + tests, and another - the pyc plugin itself.

lgtm-com · 2020-05-08T09:09:27Z

This pull request introduces 8 alerts when merging 7dfb6cb991a4232aa3694c1128a3b88eb9a7fac6 into 2a4cc15 - view on LGTM.com

new alerts:

4 for Comparison result is always the same
2 for Unsigned comparison to zero
2 for FIXME comment

libr/asm/arch/pyc/opcode.c

ret2libc · 2020-05-08T09:18:56Z

Actually, I would suggest to create two completely different PRs. One for RBig and one for PYC. They are very different things and pretty big on their own, so I would prefer to review/merge first the RBig one and then the PYC. WDYT?

radare · 2020-05-08T20:07:53Z

Agree with ret2libc

…

On 8 May 2020, at 11:19, Riccardo Schirone ***@***.***> wrote: Actually, I would suggest to create two completely different PRs. One for RBig and one for PYC. They are very different things and pretty big on their own, so I would prefer to review/merge first the RBig one and then the PYC. WDYT? — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

FXTi · 2020-05-09T06:10:31Z

Agree with ret2libc. But can we squash this into two commits? like @XVilka said.

lgtm-com · 2020-05-09T06:54:40Z

This pull request introduces 9 alerts when merging 0bc7513b86f968109b4aaa013ed51f7f52eab359 into 72f9795 - view on LGTM.com

new alerts:

5 for Comparison result is always the same
2 for Unsigned comparison to zero
2 for FIXME comment

radare · 2020-05-09T12:27:04Z

Fix the lgtm issues and lgtm

libr/anal/p/anal_pyc.c

libr/asm/arch/pyc/opcode_arg_fmt.c

libr/asm/arch/pyc/opcode_anal.c

libr/asm/arch/pyc/opcode_38.c

libr/asm/arch/pyc/opcode_37.c

XVilka · 2020-05-12T05:24:02Z

You removed dependence, but BN changes are still here. Could you please drop them?

lgtm-com · 2020-05-12T07:25:40Z

This pull request introduces 1 alert when merging 446824b into 9f2a98b - view on LGTM.com

new alerts:

1 for FIXME comment

libr/anal/p/pyc.mk

libr/asm/arch/pyc/opcode.c

libr/asm/arch/pyc/pyc_dis.c

libr/bin/format/pyc/pyc.c

libr/bin/p/bin_pyc.c

libr/bin/format/pyc/marshal.c

XVilka · 2020-05-13T02:37:43Z

I went ahead and merged it. Please send future improvements in a separate PR. This one got too long.

github-actions bot added the RAnal label May 5, 2020

FXTi requested a review from radare May 5, 2020 18:38

radare requested changes May 5, 2020

View reviewed changes

XVilka added this to the 4.5.0 - Organized Chaos milestone May 7, 2020

XVilka requested a review from ret2libc May 7, 2020 04:34

XVilka added the WIP Work-In-Progress label May 7, 2020

FXTi requested review from thestr4ng3r and wargio as code owners May 7, 2020 19:16

ret2libc reviewed May 8, 2020

View reviewed changes

libr/asm/arch/pyc/opcode.c Show resolved Hide resolved

FXTi requested review from ret2libc and radare May 9, 2020 06:07

radare requested changes May 9, 2020

View reviewed changes

FXTi added 8 commits May 12, 2020 13:08

TEST STAGE 6

533b343

FIX R_BIG_DIV

ebbc724

Ready

8365b0c

Run formatter

027bba0

Fix predecrecement

2c9f391

FiX

fa31af8

Remove bignum dependence

0eea82e

Fix

22fd4d3

FXTi added 2 commits May 12, 2020 13:32

Remove bignum

c599c54

Fix clang-formatter-diff.py

446824b

FXTi force-pushed the pyc branch from 51f40bc to 446824b Compare May 12, 2020 06:33

XVilka self-requested a review May 12, 2020 07:39

XVilka approved these changes May 12, 2020

View reviewed changes

Fix issue and format

02e7589

radare requested changes May 12, 2020

View reviewed changes

FXTi added 2 commits May 12, 2020 22:25

FIX

a53333f

FIX

29c3f86

FXTi requested review from wargio and radare May 12, 2020 14:53

FXTi added 2 commits May 12, 2020 23:51

FIX

4cbe5a9

Done

3728383

wargio suggested changes May 12, 2020

View reviewed changes

libr/bin/format/pyc/marshal.c Outdated Show resolved Hide resolved

libr/bin/format/pyc/marshal.c Outdated Show resolved Hide resolved

Fix

dad05c8

FXTi requested a review from wargio May 13, 2020 00:37

XVilka merged commit 1ffdedc into radareorg:master May 13, 2020

FXTi deleted the pyc branch May 13, 2020 07:39

Emi1305 pushed a commit to Emi1305/radare2 that referenced this pull request Jul 12, 2020

Add Python bytecode plugins (radareorg#16771)

ac839db

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add pyc plugin #16771

Add pyc plugin #16771

FXTi commented May 5, 2020 •

edited

Loading

radare commented May 5, 2020

lgtm-com bot commented May 5, 2020

lgtm-com bot commented May 5, 2020

radare left a comment

XVilka commented May 6, 2020

lgtm-com bot commented May 6, 2020

lgtm-com bot commented May 6, 2020

lgtm-com bot commented May 6, 2020

xarkes commented May 7, 2020

FXTi commented May 7, 2020

radare commented May 7, 2020 via email

lgtm-com bot commented May 7, 2020

XVilka commented May 8, 2020

lgtm-com bot commented May 8, 2020

ret2libc commented May 8, 2020

radare commented May 8, 2020 via email

FXTi commented May 9, 2020

lgtm-com bot commented May 9, 2020

radare commented May 9, 2020

XVilka commented May 12, 2020

lgtm-com bot commented May 12, 2020

XVilka commented May 13, 2020

Add pyc plugin #16771

Add pyc plugin #16771

Conversation

FXTi commented May 5, 2020 • edited Loading

radare commented May 5, 2020

lgtm-com bot commented May 5, 2020

lgtm-com bot commented May 5, 2020

radare left a comment

Choose a reason for hiding this comment

XVilka commented May 6, 2020

lgtm-com bot commented May 6, 2020

lgtm-com bot commented May 6, 2020

lgtm-com bot commented May 6, 2020

xarkes commented May 7, 2020

FXTi commented May 7, 2020

radare commented May 7, 2020 via email

lgtm-com bot commented May 7, 2020

XVilka commented May 8, 2020

lgtm-com bot commented May 8, 2020

ret2libc commented May 8, 2020

radare commented May 8, 2020 via email

FXTi commented May 9, 2020

lgtm-com bot commented May 9, 2020

radare commented May 9, 2020

XVilka commented May 12, 2020

lgtm-com bot commented May 12, 2020

XVilka commented May 13, 2020

FXTi commented May 5, 2020 •

edited

Loading