Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ISPN's start script name configurable #330

Open
mcimbora opened this issue Feb 3, 2016 · 4 comments
Open

Make ISPN's start script name configurable #330

mcimbora opened this issue Feb 3, 2016 · 4 comments
Assignees

Comments

@mcimbora
Copy link
Collaborator

mcimbora commented Feb 3, 2016

Currently hardcoded as clustered.sh/standalone.sh. There may be a need to start servers in domain mode.

@rvansa
Copy link
Member

rvansa commented Feb 3, 2016

Make sure to try out domain mode (additional support might be handy), not just add one option...

@mcimbora
Copy link
Collaborator Author

mcimbora commented Feb 3, 2016

Contributions are welcome.

@alanfx
Copy link
Contributor

alanfx commented Feb 3, 2016

This is definitely required, since clustered.sh has been removed in Infinispan 8.x. The startup scripts may be changing names again as well. standalone.sh can be used for now, since RadarGun passes a configuration file to the script.

@alanfx alanfx self-assigned this Oct 26, 2017
@alanfx
Copy link
Contributor

alanfx commented Oct 26, 2017

I have been working on this some. I don't have a PR ready yet, but I want to document the changes that I have figured out so far.

  • Handling starting in domain mode is relatively easy. It requires using the name of the startup script to also find the domain configuration file.
  • Domain mode also adds an additional configuration file for hosts. This host configuration file is not being shown in the report yet
  • The JavaProcessService plugin needs updates to deal with domain mode though. It currently assumes that if the process launched by the service is not a JVM, then the first child JVM process is. This breaks down in domain mode. The first process launched is the shell running domain.sh which spawns the "Process Controller" JVM process. The "Process Controller" spawns the "Host Controller" JVM which then spawns the actual "Server" JVM processes based on the host configuration. For the InfinispanServerService we need to be able to specify which processes (The "Server" processes) we care about and want to attach to via JMX. I am thinking this means that the JavaProcessService needs to be able to get all the children processes spawned from the initial process including the command line, and then the service can configure a RegEx string to find in the commands. The shell scripts should be able to do this with some refactoring, or pgrep may have options to do this.

That's all for now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants