Various stuff lying around #505
Conversation
|
Tests failed. Link to the results is here. |
|
Tests run successfully. Link to the results is here. |
| if (++i < payload.length && (b = payload[i]) == '[') { | ||
| while (++i < payload.length) { | ||
| b = payload[i]; | ||
| if (b >= '@' && b <= '~') break; |
There was a problem hiding this comment.
What does "color escape sequence" look like? This break statement is called even if there's [ or ] so I'm trying to see what's the goal/purpose.
There was a problem hiding this comment.
It is called only when the [ is preceded by an escape char. Subsequently there are some numbers and the sequence is terminated with a letter (included).
| @@ -28,6 +28,13 @@ private Operation(int id, String name) { | |||
| this.name = name; | |||
| } | |||
|
|
|||
| // This is useful when running report.sh | |||
| private Object readResolve() { | |||
There was a problem hiding this comment.
This method seems to be unused.
There was a problem hiding this comment.
readResolve is Java serialization hook.
| @@ -410,12 +410,6 @@ private void startServerSocket() throws IOException { | |||
| } | |||
| serverSocketChannel.socket().bind(address); | |||
| log.info("Master started and listening for connection on: " + address); | |||
| log.info("Waiting 5 seconds for server socket to open completely"); | |||
| try { | |||
| Thread.sleep(5000); | |||
There was a problem hiding this comment.
Why are you removing this? Maybe I should ask why it was there before.
There was a problem hiding this comment.
Yep, the latter is the correct question :) It has been there after some early committer (back at Mircea's days) seemingly resolved some problem. Does not make much sense to me now and I was running happily without.
|
@rvansa, there's a conflict, but otherwise looks good. |
|
Please rebase |
I've found bunch of unrelated uncommitted changes I made over past months... Can't remember exactly when and why.