Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MovieFileController doesn't return Video Dynamic Range in CustomFormats when querying by movieId #9811

Closed
2 tasks done
scalerow opened this issue Feb 29, 2024 · 9 comments
Closed
2 tasks done
Labels
Type: Support. (silent) Issue is a support request. Bot WILL NOT auto close and give a message.

Comments

@scalerow
Copy link

Is there an existing issue for this?

  • I have searched the existing open and closed issues

Current Behavior

The endpoint at /api/v3/movieFile?movieId=123 does not return Video Dynamic Range, which in turn seems to cause the wrong custom format score when looking at a movies files. See example:

MovieFileResponse

However the movie endpoint seems to be returning the correct custom formats and thus also the correct custom format score:

MovieResponse

Expected Behavior

Should return the same custom fomats and the same custom format score

Steps To Reproduce

  1. Fetch movie with X score and Video Dynamic Range -tag
  2. Open said movie in Radarr - the score will be different than when you selected it
  3. Check out history to verify that you indeed selected a movie with a higher score, with a Video Dynamic Range custom format attached

Environment

- OS: Ubuntu 23.04
- Radarr: 5.4.0.8636
- Docker Install: Yes
- Using Reverse Proxy: Yes
- Browser: Microsoft Edge 121.0.2277.128
- Database: Sqlite 3.41.2

What branch are you running?

Develop

Trace Logs? Not Optional

radarr.trace.txt

Trace Logs have been provided as applicable. Reports will be closed if the required logs are not provided.

  • I have read and followed the steps in the wiki link above and provided the required trace logs - the logs contain trace - that are relevant and show this issue.
@scalerow scalerow added Status: Needs Triage New Issue needing triage Type: Bug Issue is a bug labels Feb 29, 2024
@scalerow scalerow changed the title MovieFileController doesn't return Video Dynamic Range when querying by movieId MovieFileController doesn't return Video Dynamic Range in CustomFormats when querying by movieId Feb 29, 2024
@mynameisbogdan mynameisbogdan added the Status: Logs Needed Logs are needed to proceed with this issue label Feb 29, 2024
Copy link

👋 @scalerow, In order to help you further we'll need to see logs. You'll need to enable trace logging and replicate the problem that you encountered. Guidance on how to enable trace logging can be found in our troubleshooting guide.

@mynameisbogdan
Copy link
Collaborator

mynameisbogdan commented Feb 29, 2024

Never mind, you're using the wrong arguments for /movie and most likely you're looking at different movies.

And we're not even calculating custom formats for files in /movie.

https://radarr.video/docs/api/#/Movie/get_api_v3_movie

@mynameisbogdan mynameisbogdan closed this as not planned Won't fix, can't repro, duplicate, stale Feb 29, 2024
@mynameisbogdan mynameisbogdan added Status: Won't Fix This won't be fixed. and removed Status: Needs Triage New Issue needing triage Status: Logs Needed Logs are needed to proceed with this issue labels Feb 29, 2024
@scalerow
Copy link
Author

scalerow commented Feb 29, 2024

Never mind, you're using the wrong arguments for /movie and most likely you're looking at different movies.

Are you referring to this: "/api/v3/movieFile?movieId=123"? If so, I might a phrased myself wrong - the id 123 was just meant as an example. I'm not sure exactly where you're formatting the score, all I have noticed is that if you select a movie using Interactive search, and you select a "download" that is measured to lets say score +6500, which includes a HDR-tag. Then wait for it to download, and check it out again in the "Files" -tab, the HDR-tag is gone, and the score will be +5000.

To verify that I've selecteded a movie with score +6500 I clicked on history, which confirms that I in fact did select a movie with HDR and +6500 score.

If I enable the column "Video Dynamic Range" in the Files-tab, it also confirms that the file indeed should've had a HDR tag.

The first screenshot applied is the responses to requests radarr has sent when radarr loads the movie I've selected in my library. The second image is the request radarr sent when I clicked "History".

I did attach radarr.trace.txt to the original issue , which was downloaded after a reproduction - are they missing something?

EDIT: the second picture and the text added to it was missleading, sorry. The actual URL that picture stems from is:
/api/v3/history/movie?movieId=855

@mynameisbogdan
Copy link
Collaborator

mynameisbogdan commented Feb 29, 2024

I did attach radarr.trace.txt to the original issue , which was downloaded after a reproduction - are they missing something?

You attached the HTML output for something else. Attach the correct trace logs and we'll see after if the report is correct since history doesn't reflect the current state of the movie files.

@scalerow
Copy link
Author

I did attach radarr.trace.txt to the original issue , which was downloaded after a reproduction - are they missing something?

You attached the HTML output for something else. Attach the correct trace logs and we'll see after if the report is correct since history doesn't reflect the current state of the movie files.

Sorry, I messed up the log file - this one should be correct.
radarr.trace.txt

@mynameisbogdan
Copy link
Collaborator

What's the release title/filename with this issue?

@scalerow
Copy link
Author

What's the release title/filename with this issue?

Filname before renaming/organizing: Poor.Things.2023.2160p.WEB-DL.DDP5.1.Atmos.DV.HDR.H.265-FLUX
Filename after: Poor Things (2023) {imdb-tt14230458} [WEBDL-2160p][DV HDR10Plus][EAC3 Atmos 5.1][h265]-FLUX.mkv

@mynameisbogdan
Copy link
Collaborator

Easy fix, add the DV HDR10Plus CF too.

@scalerow
Copy link
Author

Easy fix, add the DV HDR10Plus CF too.

Feeling stupid, I'm sorry for taking up your time. Thanks alot!

@bakerboy448 bakerboy448 added Type: Support. (silent) Issue is a support request. Bot WILL NOT auto close and give a message. and removed Type: Bug Issue is a bug Status: Won't Fix This won't be fixed. labels Feb 29, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Support. (silent) Issue is a support request. Bot WILL NOT auto close and give a message.
Projects
None yet
Development

No branches or pull requests

3 participants