Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed normalization of non-numeric entries #1

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Fixed normalization of non-numeric entries #1

merged 1 commit into from
Oct 28, 2021

Conversation

piotrpospiech
Copy link
Contributor

@piotrpospiech piotrpospiech commented Oct 27, 2021

Not all arguments were trimmed. For example ' 1 ' was changed to '1', but ' a ' was still ' a '.

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2021

Codecov Report

Merging #1 (0626210) into master (8c1d15b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master        #1   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          164       164           
  Branches        40        40           
=========================================
  Hits           164       164           
Impacted Files Coverage Δ
index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c1d15b...0626210. Read the comment docs.

@radekmie radekmie changed the title Added trimming text Fixed normalization of non-numeric entries Oct 28, 2021
@radekmie radekmie merged commit f776c07 into radekmie:master Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants