Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make charts publicly linkable. #116

Closed
nathan-at-least opened this issue Mar 23, 2016 · 4 comments
Closed

Make charts publicly linkable. #116

nathan-at-least opened this issue Mar 23, 2016 · 4 comments
Assignees
@radekstepan
Labels
high

Comments

@nathan-at-least
Copy link

I am investigating burndown charts for github, and just tried this one out. I like how quickly I got it set up. However, I can't paste the link in other browsers to reproduce the same chart, even though the link has the project name:

http://radekstepan.com/burnchart/#!/zcash/zcash/23

This would be a necessary feature for our use, since we frequently share links across our remote team.
@nathan-at-least nathan-at-least mentioned this issue Mar 23, 2016
Open
@radekstepan
Copy link
Owner

I see, thanks for reporting that. It's a bug since if I add a zcash/zcash repo first, it works.

@radekstepan radekstepan self-assigned this Mar 23, 2016
radekstepan added a commit that referenced this issue Mar 25, 2016
@radekstepan
add project behind the scenes if it doesn't exist; #116
d8730c3
@radekstepan
Copy link
Owner

OK, made a fix and wrote a test for it. Please check it works for you in your environment.

@nathan-at-least
Copy link
Author

I just verified the links to a specific milestone work for me in two
different browsers. Thanks!

On Thu, Mar 24, 2016 at 6:45 PM, Radek Stepan notifications@github.com
wrote:

OK, made a fix and wrote a test for it. Please check it works for you in
your environment.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#116 (comment)

Nathan Wilcox
Least Authoritarian

email: nathan@leastauthority.com
twitter: @least_nathan

@radekstepan
Copy link
Owner

Perfect, thanks for verifying.

hughescr added a commit to ExecThread/burnchart that referenced this issue Mar 26, 2016
@hughescr
Merge remote-tracking branch 'radekstepan/master' into develop
e5f9b8d 
* radekstepan/master:
  show chart for all milestones; radekstepan#67
  separate out chart proper; radekstepan#67
  fix date ticks; closes radekstepan#114
  minify and bump
  add project behind the scenes if it doesn't exist; radekstepan#116
rickul added a commit to rickul/burnchart that referenced this issue Feb 27, 2017
@rickul
Merge branch 'master' into upstream/master
153d1f4 
* master: (414 commits)
  pass test
  radekstepan#122 switch to google firebase
  es6 classes for React; closes radekstepan#112
  stub lscache; ref radekstepan#120
  add support for querystring config; ref radekstepan#118
  support themes; ref radekstepan#118
  handle request errors with redirects; closes radekstepan#119
  show chart for all milestones; radekstepan#67
  separate out chart proper; radekstepan#67
  fix date ticks; closes radekstepan#114
  minify and bump
  add project behind the scenes if it doesn't exist; radekstepan#116
  bump
  Add react-dom required for build
  be able to delete projects; closes radekstepan#51
  validate form input, add proj behind scenes;closes radekstepan#109
  fix null milestone description; closes radekstepan#111
  suggest user or owner repos; closes radekstepan#47
  more intelligent time ticks; closes radekstepan#65
  show no progress message; closes radekstepan#93
  ...

Conflicts:
	README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@radekstepan radekstepan

Labels
high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@radekstepan @nathan-at-least