Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross-origin requests that require preflights ? #119

Closed
mgranados opened this issue Jun 7, 2016 · 2 comments
Closed

Cross-origin requests that require preflights ? #119

mgranados opened this issue Jun 7, 2016 · 2 comments
Labels
high
Milestone
Jun 8 Neuranet Ha...

Comments

@mgranados
Copy link

Hey man! Looks amazing but I cloned and tried and then went over to your demo and found out this mistake in both of them:

XMLHttpRequest cannot load https://api.github.com/repos/mbostock/d3/milestones?state=open&sort=due_date&direction=asc. 
The request was redirected to 'https://api.github.com/repositories/943149/milestones?state=open&sort=due_date&direction=asc', 
which is disallowed for cross-origin requests that require preflight.

Thus is not working right now :(
@radekstepan
Copy link
Owner

Thank for letting me know!

I will look at this when I have a minute, since this is quite critical. If you have time in the meantime, the relevant request code is in src/js/modules/github/request.js.

@radekstepan
Copy link
Owner

Post-mortem: mbostock/d3 is now d3/d3 (one of the demo repositories) and there was a bug in how we handle the redirect request errors, stopping the whole app in its tracks.

rickul added a commit to rickul/burnchart that referenced this issue Feb 27, 2017
@rickul
Merge branch 'master' into upstream/master
153d1f4 
* master: (414 commits)
  pass test
  radekstepan#122 switch to google firebase
  es6 classes for React; closes radekstepan#112
  stub lscache; ref radekstepan#120
  add support for querystring config; ref radekstepan#118
  support themes; ref radekstepan#118
  handle request errors with redirects; closes radekstepan#119
  show chart for all milestones; radekstepan#67
  separate out chart proper; radekstepan#67
  fix date ticks; closes radekstepan#114
  minify and bump
  add project behind the scenes if it doesn't exist; radekstepan#116
  bump
  Add react-dom required for build
  be able to delete projects; closes radekstepan#51
  validate form input, add proj behind scenes;closes radekstepan#109
  fix null milestone description; closes radekstepan#111
  suggest user or owner repos; closes radekstepan#47
  more intelligent time ticks; closes radekstepan#65
  show no progress message; closes radekstepan#93
  ...

Conflicts:
	README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
high
Projects
None yet
Milestone
Jun 8 Neuranet Hackday
Development

No branches or pull requests
2 participants
@radekstepan @mgranados