Added a constant FEEDWORDPRESS_USER to restrict who feed authors are set to. #20

Closed
wants to merge 9 commits into
from

Conversation

Projects
None yet
5 participants
@loongchan

I added a constant, when defined FEEDWORDPRESS_USER that will set the author to whatever the username is. It will also list the authors based on the syndicated_source_author name in the post meta. The net result is that the person can click on the author's name and see a listing of posts by that author even though the "real" author is FEEDWORDPRESS_USER
There is also a change to the performance section where you can replace and make more efficient IN queries.

michaelha and others added some commits Jan 9, 2013

Merged code from the updated version of feedwordpress from the wordpr…
…ess plugins directory.

Version of the plugin from wordpress is 2012.1218
Updated all files with newest version of feedwordpress.
All files that have changed are now updated to feedwordpress version 2012.1218.
URL white space fix
Fixed the issue where a function was not preserving white space in the syndication_source_author meta field.
The URL should now have a %20 where the white spaces should be inside the string.
Done by adding a str_replace function in the change_author_link function.
updated feedwordpress to the latest and made it so there is a constan…
…t that defines whether a custom user is FORCED to be the author or not.
@radgeek

This comment has been minimized.

Show comment
Hide comment
@radgeek

radgeek Jun 29, 2016

Owner

Unfortunately this bundles together a number of changes against a version of FWP that was current at the time this pull request was submitted, but which is now long out of date and which would require extensive conflict-resolution to merge in. The advertised features (setting all posts to be attributed to a single author, and storing feed author data in a post meta field) can be provided by other means (using settings in Syndication > Authors to force all posts to be attributed to a particular author, and by using custom fields options in Syndication > Posts & Links to set a Custom Post Setting using the desired feed element (probably $(author/name) for Atom feeds or $(dc:creator) for most RSS2 feeds). I've left this in the queue for longer than I should have without a direct response, so I'm going to go ahead and close it out without merging it.

If there are revisions you'd like me to reconsider merging, please feel free to submit a pull request against the most recent version of the current branch, but please try to submit separate pull requests for each discrete modification that you'd like to make (e.g. adding the constant is a separate issue from changes to the Performance section, etc.).

Owner

radgeek commented Jun 29, 2016

Unfortunately this bundles together a number of changes against a version of FWP that was current at the time this pull request was submitted, but which is now long out of date and which would require extensive conflict-resolution to merge in. The advertised features (setting all posts to be attributed to a single author, and storing feed author data in a post meta field) can be provided by other means (using settings in Syndication > Authors to force all posts to be attributed to a particular author, and by using custom fields options in Syndication > Posts & Links to set a Custom Post Setting using the desired feed element (probably $(author/name) for Atom feeds or $(dc:creator) for most RSS2 feeds). I've left this in the queue for longer than I should have without a direct response, so I'm going to go ahead and close it out without merging it.

If there are revisions you'd like me to reconsider merging, please feel free to submit a pull request against the most recent version of the current branch, but please try to submit separate pull requests for each discrete modification that you'd like to make (e.g. adding the constant is a separate issue from changes to the Performance section, etc.).

@radgeek radgeek closed this Jun 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment