Show docstring-note even if docstring is missed #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raxod502
requested changes
Oct 13, 2018
el-patch.el
Outdated
| (setq definition (cl-copy-list definition)) | ||
| (setf (nth docstring-idx definition) | ||
| new-docstring))))) | ||
| (setq definition (cl-copy-list definition)) |
There was a problem hiding this comment.
Please turn off indent-tabs-mode. In fact, I recommend doing this globally, since almost everyone agrees it should never be used.
There was a problem hiding this comment.
Are my changes correct?
raxod502
added a commit
that referenced
this pull request
Oct 13, 2018
raxod502
requested changes
Oct 16, 2018
el-patch.el
Outdated
| (setq definition (cl-copy-list definition)) | ||
| (setf (nth docstring-idx definition) | ||
| new-docstring))))) | ||
| (setq definition (cl-copy-list definition)) |
There was a problem hiding this comment.
I think this only needs to be in the first branch of the if clause, since the second branch doesn't actually modify definition.
el-patch.el
Outdated
| @@ -1010,6 +1015,7 @@ This mode is enabled or disabled automatically when the | |||
| (provide 'el-patch) | |||
|
|
|||
| ;; Local Variables: | |||
| ;; indent-tabs-mode: nil | |||
There was a problem hiding this comment.
I did this (and untabified the above code section) in separate commits on develop.
|
Sorry for noise. |
|
Looks good, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.