Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aggregate global Radian keybindings into minor mode map #485

Closed
hrehfeld opened this issue Jun 20, 2021 · 3 comments
Closed

Aggregate global Radian keybindings into minor mode map #485

hrehfeld opened this issue Jun 20, 2021 · 3 comments
Labels
framework keybindings minor mode

Comments

@hrehfeld
Copy link

hrehfeld commented Jun 20, 2021 •
edited
Loading

We could also take this one step further and create modes for each feature:

radian-mwheel-mode-map etc.
@hrehfeld hrehfeld changed the title Feature: put as many as possible bindings into radian-map, add radian-mode to enable/disable the map. Feature idea: put as many as possible bindings into radian-map, add radian-mode to enable/disable the map. Jun 20, 2021
@raxod502
Copy link
Member

For global keybindings, that seems reasonable, the only thing is we have to be careful with testing, since minor modes have precedence rules that are quite different from the global keymap.

@raxod502 raxod502 changed the title Feature idea: put as many as possible bindings into radian-map, add radian-mode to enable/disable the map. Aggregate global Radian keybindings into minor mode map Jul 24, 2021
@raxod502
Copy link
Member

All Radian bindings are now in radian-keymap, which is bound on a prefix. I don't think we get a lot more out of putting that single prefix binding into a keymap of its own; bind-key* actually does that transparently. But let me know if you disagree.

@hrehfeld
Copy link
Author

hrehfeld commented Feb 28, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
framework keybindings minor mode
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hrehfeld @raxod502