Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Okta Support #4

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Okta Support #4

merged 1 commit into from
Apr 12, 2022

Conversation

jbronn
Copy link
Contributor

@jbronn jbronn commented Apr 12, 2022

Adds support for using Okta as a social authentication backend. The OktaOpenIdConnect class needs a patch (via python-social-auth/social-core#663) to use the correct URLs for self-discovery -- for example, to correctly the OAuth2 endpoints you'd use:

OPENMAPS_AUTH_OIDC_ENDPOINT=https://dev-NNNNNNNN.okta.com/oauth2

Without the patch social_core would hit https://dev-NNNNNNNN.okta.com/oauth2/.well-known/openid-configuration instead of the correct endpoint of https://dev-NNNNNNNN.okta.com/.well-known/openid-configuration.

@jbronn jbronn requested a review from tlpinney April 12, 2022 15:31
Copy link
Collaborator

@tlpinney tlpinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbronn jbronn merged commit 137f030 into main Apr 12, 2022
@jbronn jbronn deleted the okta-support branch April 12, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants