Bug/okta OIDC configuration url fix #663
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #663 +/- ##
==========================================
- Coverage 77.59% 77.05% -0.55%
==========================================
Files 343 319 -24
Lines 10521 9687 -834
Branches 699 1037 +338
==========================================
- Hits 8164 7464 -700
+ Misses 2200 2071 -129
+ Partials 157 152 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Just tested this locally and seems to work |
|
Can you please rebase on current master? I have no clue why GitHub didn't execute the checks... |
* Added handling for properly generating the openid-configuration url when a custom authorization server is in use.
nickryand
force-pushed
the
bug/okta-oidc-configuration-url-fix
branch
from
b39cb7d
to
edc34f2
Compare
|
Sorry this took so long!! |
| @@ -147,6 +147,27 @@ def setUp(self): | |||
| def jwks(_request, _uri, headers): | |||
| return 200, headers, json.dumps({"keys": [self.key]}) | |||
|
|
|||
| def test_okta_oidc_config(self): | |||
There was a problem hiding this comment.
This decoupled usage of oidc_config variable from its definition what causes test to fail.
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers
why we should accept this pull request. If it fixes a bug or resolves a feature
request, be sure to link to that issue.
Types of changes
Please check the type of change your PR introduces:
Checklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.
Should fix #662 without breaking non-custom auth server configurations.