-
Notifications
You must be signed in to change notification settings - Fork 346
/
pages_controller_spec.rb
342 lines (302 loc) · 11.8 KB
/
pages_controller_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
require File.dirname(__FILE__) + '/../../spec_helper'
describe Admin::PagesController do
dataset :users, :pages
before :each do
login_as :existing
end
it "should route children to the pages controller" do
route_for(:controller => "admin/pages", :page_id => '1',
:action => "index").should == '/admin/pages/1/children'
route_for(:controller => "admin/pages", :page_id => '1',
:action => 'new').should == '/admin/pages/1/children/new'
end
describe "show" do
it "should redirect to the edit action" do
get :show, :id => 1
response.should redirect_to(edit_admin_page_path(params[:id]))
end
it "should show xml when format is xml" do
page = Page.first
get :show, :id => page.id, :format => "xml"
response.body.should == page.to_xml
end
end
describe "with invalid page id" do
[:edit, :remove].each do |action|
before do
@parameters = {:id => 999}
end
it "should redirect the #{action} action to the index action" do
get action, @parameters
response.should redirect_to(admin_pages_path)
end
it "should say that the 'Page could not be found.' after the #{action} action" do
get action, @parameters
flash[:notice].should == 'Page could not be found.'
end
end
it 'should redirect the update action to the index action' do
put :update, @parameters
response.should redirect_to(admin_pages_path)
end
it "should say that the 'Page could not be found.' after the update action" do
put :update, @parameters
flash[:notice].should == 'Page could not be found.'
end
it 'should redirect the destroy action to the index action' do
delete :destroy, @parameters
response.should redirect_to(admin_pages_path)
end
it "should say that the 'Page could not be found.' after the destroy action" do
delete :destroy, @parameters
flash[:notice].should == 'Page could not be found.'
end
end
describe "viewing the sitemap" do
integrate_views
it "should render when the homepage is present" do
get :index
response.should be_success
assigns(:homepage).should be_kind_of(Page)
response.should render_template('index')
end
it "should allow the index to render even with there are no pages" do
Page.delete_all; PagePart.delete_all
get :index
response.should be_success
assigns(:homepage).should be_nil
response.should render_template('index')
end
it "should show the tree partially expanded by default" do
get :index
response.should be_success
assert_rendered_nodes_where { |page| [nil, page_id(:home)].include?(page.parent_id) }
end
it "should show the tree partially expanded even when the expanded_rows cookie is empty" do
write_cookie('expanded_rows', '')
get :index
response.should be_success
cookies['expanded_rows'].should be_nil
assert_rendered_nodes_where { |page| [nil, page_id(:home)].include?(page.parent_id) }
end
it "should show the tree partially expanded according to the expanded_rows cookie" do
cookie = "#{page_id(:home)},#{page_id(:parent)},#{page_id(:child)}"
write_cookie('expanded_rows', cookie)
get :index
response.should be_success
assert_rendered_nodes_where { |page| [nil, page_id(:home), page_id(:parent), page_id(:child)].include?(page.parent_id) }
end
it "should show the tree with a mangled cookie" do
cookie = "#{page_id(:home)},#{page_id(:parent)},:#*)&},9a,,,"
write_cookie('expanded_rows', cookie)
get :index
response.should be_success
assert_rendered_nodes_where { |page| [nil, page_id(:home), page_id(:parent)].include?(page.parent_id) }
assigns(:homepage).should_not be_nil
end
it "should render the appropriate children when branch of the site map is expanded via AJAX" do
xml_http_request :get, :index, :page_id => page_id(:home), :level => '1'
response.should be_success
assigns(:level).should == 1
response.body.should_not have_text('<head>')
response.content_type.should == 'text/html'
response.charset.should == 'utf-8'
end
end
describe "permissions" do
[:admin, :designer, :non_admin, :existing].each do |user|
{
:post => :create,
:put => :update,
:delete => :destroy
}.each do |method, action|
it "should require login to access the #{action} action" do
logout
send method, action, :id => Page.first.id
response.should redirect_to('/admin/login')
end
it "should allow access to #{user.to_s.humanize}s for the #{action} action" do
login_as user
controller.should_receive(:paginated?).and_return(false)
send method, action, :id => Page.first.id
response.should redirect_to('http://test.host/admin/pages')
end
end
end
[:index, :show, :new, :edit, :remove].each do |action|
before :each do
@parameters = lambda do
case action
when :index
{}
when :new
{:page_id => page_id(:home)}
else
{:id => Page.first.id}
end
end
end
it "should require login to access the #{action} action" do
logout
lambda { send(:get, action, @parameters.call) }.should require_login
end
if action == :show
it "should request authentication for API access on show" do
logout
get action, :id => page_id(:home), :format => "xml"
response.response_code.should == 401
end
else
it "should allow access to admins for the #{action} action" do
lambda {
send(:get, action, @parameters.call)
}.should restrict_access(:allow => [users(:admin)],
:url => '/admin/pages')
end
it "should allow access to designers for the #{action} action" do
lambda {
send(:get, action, @parameters.call)
}.should restrict_access(:allow => [users(:designer)],
:url => '/admin/pages')
end
it "should allow non-designers and non-admins for the #{action} action" do
lambda {
send(:get, action, @parameters.call)
}.should restrict_access(:allow => [users(:non_admin), users(:existing)],
:url => '/admin/pages')
end
end
end
end
describe '#preview' do
let(:preview_page){ pages(:home) }
let(:body_id){ preview_page.part('body').id }
let(:preview_params){
{'page' => {
'title' => 'BOGUS',
'id' => preview_page.id.to_s,
'parts_attributes' => [{'content' => 'TEST', 'id' => body_id.to_s}] } }
}
it 'should render the page with changes' do
request.stub!(:referer).and_return("/admin/pages/#{preview_page.id}/edit")
post :preview, preview_params
response.body.should eql('TEST')
end
describe 'new child' do
it 'should not save any changes' do
page_count = Page.count
request.stub!(:referer).and_return("/admin/pages/#{preview_page.id}/edit")
post :preview, preview_params
Page.count.should == page_count
end
end
# TODO: transactional fixtures must be turned off for this to be able to test the transactions properly
# describe 'edit existing page' do
# it 'should not save any changes' do
# request.stub!(:referer).and_return("/admin/pages/#{preview_page.id}/edit")
# original_date = preview_page.updated_at
# put :preview, preview_params
# non_updated_page = Page.find(preview_page.id)
# non_updated_page.title.should_not == 'BOGUS'
# non_updated_page.updated_at.to_i.should == original_date.to_i
# end
# end
end
describe "prompting page removal" do
integrate_views
# TODO: This should be in a view or integration spec
it "should render the expanded descendants of the page being removed" do
get :remove, :id => page_id(:parent), :format => 'html' # shouldn't need this!
rendered_pages = [:parent, :child, :grandchild, :great_grandchild, :child_2, :child_3].map {|p| pages(p) }
rendered_pages.each do |page|
response.should have_tag("tr#page_#{page.id}")
end
end
end
describe '#new' do
it "should initialize meta and buttons_partials in new action" do
get :new, :page_id => page_id(:home)
response.should be_success
assigns(:meta).should be_kind_of(Array)
assigns(:buttons_partials).should be_kind_of(Array)
end
it "should set the parent_id from the parameters" do
get :new, :page_id => page_id(:home)
assigns(:page).parent_id.should == page_id(:home)
end
it "should set the @page variable" do
home = pages(:home)
new_page = home.class.new_with_defaults
new_page.parent_id = home.id
Page.stub!(:new_with_defaults).and_return(new_page)
get :new, :page_id => home.id
assigns(:page).should == new_page
end
it "should create a page based on the given param" do
get :new, :page_id => page_id(:home), :page_class => 'FileNotFoundPage'
assigns(:page).should be_a(FileNotFoundPage)
end
it "should gracefully handle bogus page params" do
get :new, :page_id => page_id(:home), :page_class => 'BogusPage'
assigns(:page).should be_a(Page)
end
it "should instantiate a new page of the given class" do
PagesControllerSpecPage = Class.new(Page)
PagesControllerSpecPage.stub!(:default_page_parts).and_return(PagePart.new :name => "my_part")
get :new, :page_id => page_id(:home), :page_class => 'PagesControllerSpecPage'
assigns(:page).parts.map(&:name).should include('my_part')
end
end
describe '#update' do
it 'should update the page updated_at on every update' do
start_updated_at = pages(:home).updated_at
put :update, :id => page_id(:home), :page => {:breadcrumb => 'Homepage'} and sleep(1)
next_updated_at = pages(:home).updated_at
lambda{ start_updated_at <=> next_updated_at }.should be_true
put :update, :id => page_id(:home), :page => {:breadcrumb => 'Homepage'} and sleep(1)
final_updated_at = pages(:home).updated_at
lambda{ next_updated_at <=> final_updated_at }.should be_true
end
end
it "should initialize meta and buttons_partials in edit action" do
get :edit, :id => page_id(:home)
response.should be_success
assigns(:meta).should be_kind_of(Array)
assigns(:buttons_partials).should be_kind_of(Array)
end
it "should clear the page cache when saved" do
Radiant::Cache.should_receive(:clear)
put :update, :id => page_id(:home), :page => {:breadcrumb => 'Homepage'}
end
describe "@body_classes" do
it "should return 'reversed' when the action_name is 'new'" do
get :new
assigns[:body_classes].should == ['reversed']
end
it "should return 'reversed' when the action_name is 'edit'" do
get :edit, :id => 1
assigns[:body_classes].should == ['reversed']
end
it "should return 'reversed' when the action_name is 'create'" do
post :create
assigns[:body_classes].should == ['reversed']
end
it "should return 'reversed' when the action_name is 'update'" do
put :update, :id => 1
assigns[:body_classes].should == ['reversed']
end
end
protected
def assert_rendered_nodes_where(&block)
wanted, unwanted = Page.find(:all).partition(&block)
wanted.each do |page|
response.should have_tag("tr[id=page_#{page.id}]")
end
unwanted.each do |page|
response.should_not have_tag("tr[id=page_#{page.id}]")
end
end
def write_cookie(name, value)
request.cookies[name] = value
end
end