Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config.extension -= does not work #200

Closed
ehaselwanter opened this issue Mar 27, 2011 · 7 comments
Closed

config.extension -= does not work #200

ehaselwanter opened this issue Mar 27, 2011 · 7 comments
Milestone

Comments

@ehaselwanter
Copy link

config.extensions -= [:sheets] does still load sheets

@saturnflyer
Copy link
Member

config.extensions -= [:sheets] does not load the sheets extension. The problem that existed is that Rails would find a "StylesheetPage" when we constantize that string and that Page subclass had no knowledge of acts_as_tree, causing an error in the views on the main page index.
Does this describe the problem that you saw? Please try again on edge.

@saturnflyer
Copy link
Member

scratch that. the implemented fix seems to have a bug in development mode

@ehaselwanter
Copy link
Author

its a bug in remove. I want to say NOT to load sheets at the moment. so if I have a :all in config.extensions it should still not load extensions in config.extensions -= []

@ehaselwanter
Copy link
Author

or maybe I don't use it as intended?

@saturnflyer
Copy link
Member

Can you describe the problem? I think we either have 1 bug that's not actually loading the extension but causes problems with Page subclasses, or that an another bug where the Sheets interfaces is being loaded.
Are you still seeing the interface for sheets? Or is this a problem on the pages index with Javascript or Stylesheet pages existing?

@ehaselwanter
Copy link
Author

I am currently still running sns, so I wanted to avoid loading :sheets. I thought that if I put I use config.extensions -= [:sheets] it does not get loaded. This was not true. Sheets got loaded occupying the path and showing in the admin interface.

but maybe this is just wrong?

config.extensions -= [:sheets]

is a array operation, right? so it can't work that way, cause it would have to remove :sheets from :all ... or?

@saturnflyer saturnflyer reopened this Mar 29, 2011
@saturnflyer
Copy link
Member

config.extensions -= [:sheets] should work; it's a bug if it doesn't.

I'll try this out with an instance using SNS too. It might be a bug in the case of using config.extensions = [:all]

Thanks for clarifying.

rx pushed a commit to voomify/radiant that referenced this issue Jul 19, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants