Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: add support for shapely 2 #195

Merged
merged 2 commits into from
Feb 13, 2023

Conversation

adamjstewart
Copy link
Contributor

Proposed Changes

This PR adds support for shapely 2. As far as I can tell, I don't see any usage that requires shapely 1, but hopefully the unit tests will confirm this.

Checklist for Submitter

  • Updated/added any relevant documentation.
  • Added changes/fixes to the Changelog.
  • Updated any unit tests affected by these changes and/or added unit tests to cover any additions, or this is N/A.
  • Added changes to the Architecture Decision Records (ADR), or this is N/A.

Related Issues

We are trying to update TorchGeo to support radiant-mlhub 0.5+ but noticed that we were unable to test the latest versions of both radiant-mlhub and shapely due to an overly strict dependency pin.

@PowerChell PowerChell self-requested a review February 13, 2023 18:05
Copy link
Contributor

@PowerChell PowerChell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR passed all the tests! Approved!

@PowerChell PowerChell merged commit 7d315e3 into radiantearth:main Feb 13, 2023
@adamjstewart adamjstewart deleted the deps/shapely branch February 13, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants