Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved thumbnail from links to assets; updated asset format #55

Merged
merged 4 commits into from
Mar 15, 2018
Merged

moved thumbnail from links to assets; updated asset format #55

merged 4 commits into from
Mar 15, 2018

Conversation

joshfix
Copy link
Contributor

@joshfix joshfix commented Mar 8, 2018

No description provided.

@cholmes
Copy link
Contributor

cholmes commented Mar 8, 2018

Could you break these in to two pull requests? Partially because I think both need to a modify a lot more files. Definitely the main json definition at https://github.com/radiantearth/stac-spec/blob/dev/json-spec/json-spec.md Ideally we'd update the json-schema folder and all the examples in one PR. Though I think just two main 'sample' examples would be ok. Plus update the narrative texts.

I'm happy to merge in a pull request that's a subset of everything to be done, but we should at least open issues on what needs to be updated.

@joshfix
Copy link
Contributor Author

joshfix commented Mar 8, 2018

Chris, when you originally recommended two PRs, I thought you were referring to one PR for the change to make thumbnails mandatory for assets, and one PR to make the second "something else" required asset. I'm not exactly sure how to split this into two PRs... would you like one PR that keeps assets as an array but simply removes thumbnail as a mandatory link? And a second that changes assets to a dictionary and includes updates to all the samples?

@cholmes
Copy link
Contributor

cholmes commented Mar 15, 2018

Hey @joshfix - I was thinking we'd try to break things up in to lots of granular commits. But I'm thinking of just making master/ a 'stable' branch and just merge lots of stuff in to dev. So these PR's should be fine to just do in one big one. Thanks for all the work!

@cholmes cholmes merged commit c68e770 into radiantearth:dev Mar 15, 2018
@cholmes
Copy link
Contributor

cholmes commented Mar 15, 2018

Merged this in, as dev branch is now an open for any changes that get us closer to the 0.4 milestone. Tackles parts of #61, #62, #59 and #65

@cholmes cholmes added this to the 0.4.0 milestone Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants