Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/task process id #3033

Merged
merged 37 commits into from
Dec 4, 2023
Merged

Feature/task process id #3033

merged 37 commits into from
Dec 4, 2023

Conversation

mtitov
Copy link
Contributor

@mtitov mtitov commented Sep 13, 2023

Preserve process ID for tasks with executable mode

This feature will be used in the RECUP project to determine files (tracked by Darshan), which are associated with the corresponding task.

@mtitov mtitov self-assigned this Sep 13, 2023
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (f2ef1a2) 44.20% compared to head (997ca83) 44.15%.

Files Patch % Lines
src/radical/pilot/agent/staging_output/default.py 0.00% 12 Missing ⚠️
src/radical/pilot/task.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3033      +/-   ##
==========================================
- Coverage   44.20%   44.15%   -0.05%     
==========================================
  Files          96       96              
  Lines       10569    10583      +14     
==========================================
+ Hits         4672     4673       +1     
- Misses       5897     5910      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtitov mtitov changed the base branch from devel_nodb_2 to devel September 27, 2023 16:26
@mtitov mtitov marked this pull request as ready for review September 29, 2023 17:38
@mturilli mturilli marked this pull request as draft October 4, 2023 14:20
@mtitov
Copy link
Contributor Author

mtitov commented Nov 30, 2023

validated on Frontier

@mtitov mtitov marked this pull request as ready for review November 30, 2023 17:22
Copy link
Member

@andre-merzky andre-merzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment, but in general looks correct and ready to merge.

src/radical/pilot/agent/staging_output/default.py Outdated Show resolved Hide resolved
@mtitov mtitov enabled auto-merge December 4, 2023 22:59
@mtitov mtitov merged commit 81c2b6e into devel Dec 4, 2023
30 checks passed
@mtitov mtitov deleted the feature/task_process_id branch December 4, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants