Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clear RAPTOR and Configuration tutorials notebooks #3066

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Conversation

AymenFJA
Copy link
Contributor

No description provided.

@AymenFJA AymenFJA requested a review from mtitov October 19, 2023 19:07
@AymenFJA AymenFJA self-assigned this Oct 19, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #3066 (e4829ce) into devel (5318046) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            devel    #3066   +/-   ##
=======================================
  Coverage   43.90%   43.90%           
=======================================
  Files          96       96           
  Lines       10563    10563           
=======================================
  Hits         4638     4638           
  Misses       5925     5925           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@mtitov mtitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@AymenFJA
Copy link
Contributor Author

AymenFJA commented Oct 20, 2023

multiple_pilots and specifically pilot.00001 only fail with:

 /home/runner/radical.pilot.sandbox/rp.session.fv-az410-569.runner.019649.0000/pilot.0001//bootstrap_0.sh: line 912: /home/runner/radical.pilot.sandbox/rp.session.fv-az410-569.runner.019649.0000/pilot.0001/bin/activate: No such file or directory
 39 Loading of virtual env failed!

@mtitov
Copy link
Contributor

mtitov commented Oct 20, 2023

Looks like it is a race condition, and pilots on the same machine can interfere with each other

from bootstrap_0.out

VIRTENV           : /home/runner/radical.pilot.sandbox/ve.local.localhost.1.42.0
/home/runner/radical.pilot.sandbox/rp.session.fv-az410-569.runner.019649.0000/pilot.0001//bootstrap_0.sh: line 1595: cd: /home/runner/radical.pilot.sandbox/ve.local.localhost.1.42.0: No such file or directory
VIRTENV normalized: /home/runner/radical.pilot.sandbox/rp.session.fv-az410-569.runner.019649.0000/pilot.0001

and this does from here

mkdir -p "$VIRTENV"
VIRTENV=`(cd $VIRTENV; pwd -P)`
rmdir "$VIRTENV" 2>/dev/null

and it is possible for some pilot to have incorrect VIRTENV env variable

@AymenFJA AymenFJA merged commit 04fdbd3 into devel Oct 25, 2023
29 of 30 checks passed
@AymenFJA AymenFJA deleted the cleanup/tutorials branch October 25, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants