Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AgentComponent to forward all state notifications #3088

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

andre-merzky
Copy link
Member

Fix forwarding of agent side state notifications. This fixes #3087

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (0ab8fab) 43.99% compared to head (d9847bf) 44.00%.
Report is 1 commits behind head on devel.

Files Patch % Lines
src/radical/pilot/raptor/master.py 33.33% 2 Missing ⚠️
src/radical/pilot/utils/component.py 71.42% 2 Missing ⚠️
src/radical/pilot/agent/agent_0.py 50.00% 1 Missing ⚠️
src/radical/pilot/agent/agent_n.py 50.00% 1 Missing ⚠️
src/radical/pilot/agent/executing/base.py 50.00% 1 Missing ⚠️
src/radical/pilot/agent/scheduler/base.py 50.00% 1 Missing ⚠️
src/radical/pilot/agent/staging_input/base.py 50.00% 1 Missing ⚠️
src/radical/pilot/agent/staging_output/base.py 50.00% 1 Missing ⚠️
src/radical/pilot/pilot_manager.py 50.00% 1 Missing ⚠️
src/radical/pilot/pmgr/launching/base.py 50.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #3088   +/-   ##
=======================================
  Coverage   43.99%   44.00%           
=======================================
  Files          96       96           
  Lines       10574    10577    +3     
=======================================
+ Hits         4652     4654    +2     
- Misses       5922     5923    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mtitov mtitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added one comment and have couple questions regarding rpu.Worker

  • do we keep it for Agent_0 and Agent_N?
  • for rp.worker.Stager, should we switch to ClientComponent?

src/radical/pilot/pmgr/launching/base.py Outdated Show resolved Hide resolved
@andre-merzky
Copy link
Member Author

added one comment and have couple questions regarding rpu.Worker

* do we keep it for `Agent_0` and `Agent_N`?

* for `rp.worker.Stager`, should we switch to `ClientComponent`?

Yeah, we can probably get rid of the Worker class by now...

@mtitov
Copy link
Contributor

mtitov commented Nov 22, 2023

as an intermediate testing - RP from this branch runs successfully on Lassen (tmgr.wait_tasks(uids=tasks_uids, state=rp.AGENT_EXECUTING) waits correctly)

Copy link
Contributor

@mtitov mtitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@andre-merzky andre-merzky merged commit da98851 into devel Nov 22, 2023
30 checks passed
@andre-merzky andre-merzky deleted the feature/agent_component branch November 22, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

agent side state notifications are not forwarded to client side
2 participants