-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AgentComponent to forward all state notifications #3088
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## devel #3088 +/- ##
=======================================
Coverage 43.99% 44.00%
=======================================
Files 96 96
Lines 10574 10577 +3
=======================================
+ Hits 4652 4654 +2
- Misses 5922 5923 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added one comment and have couple questions regarding rpu.Worker
- do we keep it for
Agent_0
andAgent_N
? - for
rp.worker.Stager
, should we switch toClientComponent
?
Yeah, we can probably get rid of the Worker class by now... |
as an intermediate testing - RP from this branch runs successfully on Lassen ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
Fix forwarding of agent side state notifications. This fixes #3087