Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed collecting service related data in registry #3093

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Conversation

mtitov
Copy link
Contributor

@mtitov mtitov commented Nov 27, 2023

No description provided.

@mtitov mtitov self-assigned this Nov 27, 2023
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (15900cf) 44.00% compared to head (8905f11) 44.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3093      +/-   ##
==========================================
+ Coverage   44.00%   44.20%   +0.19%     
==========================================
  Files          96       96              
  Lines       10569    10569              
==========================================
+ Hits         4651     4672      +21     
+ Misses       5918     5897      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mturilli mturilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mtitov mtitov merged commit 6dec056 into devel Nov 27, 2023
27 of 30 checks passed
@mtitov mtitov deleted the fix/service_cb branch November 27, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants