This repository has been archived by the owner on Apr 29, 2024. It is now read-only.
Patch fixes #451
Merged
Patch fixes #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloudhead
force-pushed
the
cloudhead/patch
branch
from
2b6b66d
to
e20f157
Compare
slack-coder
reviewed
Mar 17, 2023
| None, | ||
| None, | ||
| )?; | ||
| working.find_commit(patch_head.into())? |
There was a problem hiding this comment.
Maybe move this code into a private method? That way the condition and resulting actions are clear.
|
Otherwise 👍 |
cloudhead
force-pushed
the
cloudhead/patch
branch
from
e20f157
to
115e339
Compare
The description is not actually optional, so don't return an `Option`.
Since the patch may not have been pulled into the working copy, we shouldn't rely on it for displaying patch information.
Before this change, `rad patch checkout` would fail if the patch commits were not in the working copy.
cloudhead
force-pushed
the
cloudhead/patch
branch
from
115e339
to
5ccf380
Compare
FintanH
reviewed
Mar 20, 2023
|
|
||
| pub fn run( | ||
| storage: &Repository, | ||
| git_workdir: &git::raw::Repository, | ||
| stored: &Repository, |
There was a problem hiding this comment.
Why the rename, out of interest?
There was a problem hiding this comment.
storage is confusing when it doesn't refer to Storage, no?
I think a nice convention if there are two repositories is stored for the stored copy and working for the working copy. That was the idea.
There was a problem hiding this comment.
Ya, that makes sense! I only noticed the working copy param after I sent off the comment, but you confirmed my hunch 😄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits.