Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

profile: management of profiles #720

Merged
merged 3 commits into from
Jul 27, 2021
Merged

profile: management of profiles #720

merged 3 commits into from
Jul 27, 2021

Conversation

FintanH
Copy link
Contributor

@FintanH FintanH commented Jun 30, 2021 •
edited
Loading

Adding functionality for management of Profiles. Specifically the following functions:

  • new
  • get
  • set
  • list

TODO:

  • Add documentation to functions
  • Test unhappy path of profile id not existing

@FintanH FintanH marked this pull request as ready for review July 1, 2021 09:17
@FintanH FintanH requested a review from a team as a code owner July 1, 2021 09:17
@FintanH FintanH mentioned this pull request Jul 1, 2021
Merged
Base automatically changed from finto/profile to master July 2, 2021 07:34
kim
kim previously approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@kim kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@FintanH
profile: add CRU functionality
6d7c73d 
We add functionality for creation, reading, and updating of `Profile`'s.

Signed-off-by: Fintan Halpenny <fintan.halpenny@gmail.com>
@FintanH
test: add tests for profile operations
ae0065d 
Signed-off-by: Fintan Halpenny <fintan.halpenny@gmail.com>
@FintanH
profile: add AsRef<Path> impl for ProfileId
fb03315 
Signed-off-by: Fintan Halpenny <fintan.halpenny@gmail.com>
@FintanH FintanH merged commit fb03315 into master Jul 27, 2021
@FintanH FintanH deleted the finto/profile-mgmt branch July 27, 2021 11:49
@github-pages github-pages bot temporarily deployed to github-pages July 27, 2021 11:49 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim kim kim left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FintanH @kim