This repository has been archived by the owner on Aug 1, 2022. It is now read-only.
fix: show commit not found screen instead of error #2451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudolfs
changed the title
|
Great empty state
|
geigerzaehler
approved these changes
Oct 4, 2021
ui/src/screen/project/source.ts
Outdated
| }) | ||
| ); | ||
| const e = error.fromUnknown(err); | ||
| if (!e.message.match("object not found")) { |
There was a problem hiding this comment.
Could you flip the if/else branches and get rid of the negation?
Show a placeholder if the commit hasn't been replicated or doesn't exist. This also fixes incorrect anchor ordering. Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
rudolfs
force-pushed
the
rudolfs/anchor-fixup
branch
from
51bf94c
to
0619c51
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show a placeholder if the commit isn't replicated instead of an error message. This also fixes the anchor list not being properly ordered, now the latest anchor is at the top and the list is sorted by timestamp oldest at the bottom.
Closes #2448.