Added methods to find linewidth maps #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… moment2() methods to point out that this is the variance not linewidth. Also add linewidth_sigma and linewidth_fwhm methods to make linewidth maps.
|
@keflavich - ready for review! |
|
Where does the changelog entry go? Do I make a new 0.4.0 section? |
|
@astrofrog Yeah, new section is needed. 0.4 sounds good to me, since this is an API change and the 0.3.0->0.3.1 was only bugfixes |
|
|
||
| For an explanation of the ``how`` parameter, see :meth:`moment`. | ||
| """ | ||
| with np.errstate(invalid='ignore'): |
There was a problem hiding this comment.
we need this in many more locations in SpectralCube
|
👍 |
|
@keflavich - I've added the changelog entry |
|
@keflavich - good to merge? |
keflavich
added a commit
that referenced
this pull request
Feb 7, 2016
Added methods to find linewidth maps
keflavich
added a commit
to keflavich/spectral-cube
that referenced
this pull request
Feb 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @keflavich