Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First fix post release #402

Merged
merged 14 commits into from
Nov 15, 2021
Merged

Conversation

erwanp
Copy link
Member

@erwanp erwanp commented Nov 15, 2021

Description

  • Activate pytables support for new HITRAN full-database format : Fixes Cannot change the MEMORY_MAPPING_ENGINE #401
  • option not to parse local/Global quanta
  • fix ~/.radisdb folder not created by default
  • automatically show line_survey if run from Spyder (already worked in Jupyter Lab) @minouHub
  • fix problems with ExoMol parser ( by @minouHub )
  • "auto" mode for MEMORY_MAPPING_ENGINE (set by default). -> will use "vaex", unless you're on Spyder IDE, thne will use "pytables" (HITRAN/HITEMP) or "feather" (ExoMol). (note : we detect we're on Spyder IDE by looking at environment variables; may fail if someone somehow declared a "SPYDER" key in thier environemnet variables)
  • test Pytables & vaex modes for HITRAN & HITEMP (in separate folders)

@erwanp erwanp requested a review from minouHub November 15, 2021 07:28
@lgtm-com
Copy link

lgtm-com bot commented Nov 15, 2021

This pull request fixes 5 alerts when merging 0e7a4ba into 27edb9e - view on LGTM.com

fixed alerts:

  • 2 for Module is imported more than once
  • 1 for First parameter of a method is not named 'self'
  • 1 for Non-callable called
  • 1 for Wrong number of arguments in a call

erwanp and others added 4 commits November 15, 2021 09:29
@lgtm-com
Copy link

lgtm-com bot commented Nov 15, 2021

This pull request introduces 1 alert and fixes 7 when merging 32a2857 into 27edb9e - view on LGTM.com

new alerts:

  • 1 for Module is imported more than once

fixed alerts:

  • 3 for Module is imported more than once
  • 1 for First parameter of a method is not named 'self'
  • 1 for Non-callable called
  • 1 for Module is imported with 'import' and 'import from'
  • 1 for Wrong number of arguments in a call

…ines

add two separate tests for HITRAN CO database, on pytables & vaex engines
fix tests with test-databases created in separate folders
@lgtm-com
Copy link

lgtm-com bot commented Nov 15, 2021

This pull request introduces 5 alerts and fixes 7 when merging a5639ae into 27edb9e - view on LGTM.com

new alerts:

  • 3 for Unused local variable
  • 2 for Module is imported with 'import' and 'import from'

fixed alerts:

  • 3 for Module is imported more than once
  • 1 for First parameter of a method is not named 'self'
  • 1 for Non-callable called
  • 1 for Module is imported with 'import' and 'import from'
  • 1 for Wrong number of arguments in a call

fix setting of 'auto' value
@erwanp erwanp added this to the 0.11.1 milestone Nov 15, 2021
@erwanp erwanp merged commit 8ad64dc into radis:develop Nov 15, 2021
@lgtm-com
Copy link

lgtm-com bot commented Nov 15, 2021

This pull request introduces 2 alerts and fixes 7 when merging f0fed78 into 27edb9e - view on LGTM.com

new alerts:

  • 2 for Module is imported with 'import' and 'import from'

fixed alerts:

  • 3 for Module is imported more than once
  • 1 for First parameter of a method is not named 'self'
  • 1 for Non-callable called
  • 1 for Module is imported with 'import' and 'import from'
  • 1 for Wrong number of arguments in a call

@erwanp erwanp added the bug Something isn't working label Nov 15, 2021
@erwanp erwanp mentioned this pull request Nov 15, 2021
1 task
@erwanp erwanp deleted the fix/first-fix-post-release branch May 17, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot change the MEMORY_MAPPING_ENGINE
2 participants