Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update defaults (vaex, DIT weights=simple) #422

Merged
merged 6 commits into from Mar 20, 2022
Merged

update defaults (vaex, DIT weights=simple) #422

merged 6 commits into from Mar 20, 2022

Conversation

erwanp
Copy link
Member

@erwanp erwanp commented Mar 6, 2022

Description

  • make DIT method 'simple weights' the default. Fixes Lineshape issues at low pressure with DIT min-RMS  #421
  • update vaex to 4.8 and remove warnings of incompatibility with Spyder. Vaex is now the default for all configurations
  • fix some UX problems (using truncation=None didn't work)
  • reduce default verbose when printing conditions
  • update docs and references

Fixes #

@erwanp erwanp added performance interface not related to the physics of the code documentation related to the docs https://radis.readthedocs.io/ labels Mar 6, 2022
@erwanp erwanp added this to the 0.12.1 milestone Mar 6, 2022
This was referenced Mar 6, 2022
Closed
Closed
Open
@erwanp erwanp mentioned this pull request Mar 19, 2022
Closed
@codecov-commenter
Copy link

Codecov Report

Merging #422 (b04c376) into develop (d2f0528) will increase coverage by 0.03%.
The diff coverage is 76.00%.

@@             Coverage Diff             @@
##           develop     #422      +/-   ##
===========================================
+ Coverage    77.03%   77.06%   +0.03%     
===========================================
  Files          161      161              
  Lines        18664    18639      -25     
===========================================
- Hits         14378    14365      -13     
+ Misses        4286     4274      -12

@erwanp erwanp merged commit e3da45a into radis:develop Mar 20, 2022
@erwanp erwanp mentioned this pull request Apr 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation related to the docs https://radis.readthedocs.io/ interface not related to the physics of the code performance
Projects
None yet
Milestone
0.12.1
Development

Successfully merging this pull request may close these issues.

Lineshape issues at low pressure with DIT min-RMS
2 participants
@erwanp @codecov-commenter