Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate cloud/non-cloud tests #6587

Closed
wants to merge 3 commits into from
Closed

Separate cloud/non-cloud tests #6587

wants to merge 3 commits into from

Conversation

vinayada1
Copy link
Contributor

@vinayada1 vinayada1 commented Oct 26, 2023

Description

Currently, all the functional tests run only with an approved "/ok-to-test" command. Only tests that deploy cloud resources or publish stuff really require an approval. This PR separates out the tests that do not need an approval to run as a part of the regular build workflow. The /ok-to-test command will now run only tests that deploy cloud resources

Type of change

  • This pull request adds or changes features of Radius and has an approved issue (issue link required).

Fixes: #6588

Auto-generated summary

🤖 Generated by Copilot at efaffae

Summary

🧪☁️🛠️

This pull request adds support for running functional tests that require cloud resources for the radius project. It modifies the GitHub workflows and the make targets to run different types of tests. It also moves the existing cloud-based tests to a new test/functional-cloud directory and adds new test files for the extender and Terraform recipe features.

To test radius with cloud resources
We added some make targets and processes
We use rad and bicep
And terraform to equip
Our workflow with functional successes

Walkthrough

  • Add a new step to the build workflow to run functional tests that do not require cloud resources (link)
  • Rename and modify the existing step to run functional tests that require cloud resources and append "-cloud" to the make command argument (link, link)
  • Add new make targets to run functional tests for shared, Datastores RP, and UCP components using the test-functional-cloud directory (link, link, link)
  • Add links to the documentation for writing and running functional tests in the test-functional-cloud/README.md file (link)
  • Add a new test file for testing the extender resource using a Bicep recipe that deploys an AWS S3 bucket (test/functional-cloud/shared/resources/extender_test.go, link)
  • Add a new test file for testing the Terraform recipe functionality using the extender resource (test/functional-cloud/shared/resources/recipe_terraform_test.go, link)
  • Rename several test files and directories from test/functional to test/functional-cloud to reflect the cloud resource requirement (link, link, link, link, link, link, link, link, link, link, link, link, link, link)

@vinayada1 vinayada1 requested review from a team as code owners October 26, 2023 20:45
@github-actions
Copy link

github-actions bot commented Oct 26, 2023

Test Results

2 975 tests  ±0   2 963 ✔️ ±0   2m 47s ⏱️ -11s
   256 suites ±0        12 💤 ±0 
       1 files   ±0          0 ±0 

Results for commit df845df. ± Comparison against base commit d680f7d.

This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.
github.com/radius-project/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/aec64120-4601-4820-8c0f-ebb69e98211b
github.com/radius-project/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/aec64120-4601-4820-8c0f-ebb69e98211b#01
github.com/radius-project/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/490686f5-786e-4c09-a08a-7e340e3d9ed8
github.com/radius-project/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/490686f5-786e-4c09-a08a-7e340e3d9ed8#01

♻️ This comment has been updated with latest results.

@vinayada1 vinayada1 force-pushed the tests-separate branch 3 times, most recently from 7561093 to 5c7f2bb Compare October 26, 2023 21:32
@github-actions
Copy link

65.2

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 65.2 %
  • main branch coverage: 65.2 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@github-actions
Copy link

65.2

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 65.2 %
  • main branch coverage: 65.2 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@github-actions
Copy link

github-actions bot commented Oct 26, 2023

⌛ Starting datastoresrp functional tests...

⌛ Starting ucp functional tests...

@vinayada1
Copy link
Contributor Author

/ok-to-test

@github-actions
Copy link

github-actions bot commented Oct 26, 2023

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref a448e6a
Unique ID a0444287f1
Image tag pr-a0444287f1
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.11.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-a0444287f1
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-a0444287f1
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-a0444287f1
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-a0444287f1
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting samples functional tests...
⌛ Starting ucp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting shared functional tests...
✅ datastoresrp functional tests succeeded
✅ ucp functional tests succeeded
✅ msgrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ samples functional tests succeeded
✅ daprrp functional tests succeeded
✅ shared functional tests succeeded

@vinayada1
Copy link
Contributor Author

/ok-to-test

@github-actions
Copy link

github-actions bot commented Oct 26, 2023

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref a448e6a
Unique ID 54ace317e1
Image tag pr-54ace317e1
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.11.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-54ace317e1
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-54ace317e1
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-54ace317e1
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-54ace317e1
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting samples functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting ucp functional tests...
⌛ Starting shared functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting datastoresrp functional tests...
✅ datastoresrp functional tests succeeded
✅ ucp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ samples functional tests succeeded
✅ msgrp functional tests succeeded
✅ daprrp functional tests succeeded
✅ shared functional tests succeeded

@vinayada1 vinayada1 force-pushed the tests-separate branch 2 times, most recently from a32cb7e to cb9581b Compare October 26, 2023 22:55
@vinayada1
Copy link
Contributor Author

/ok-to-test

@github-actions
Copy link

github-actions bot commented Oct 26, 2023

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref cb9581b
Unique ID b37a74e928
Image tag pr-b37a74e928
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.11.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-b37a74e928
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-b37a74e928
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-b37a74e928
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-b37a74e928
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting msgrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting ucp functional tests...
⌛ Starting shared functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting datastoresrp functional tests...
✅ ucp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ shared functional tests succeeded

@github-actions
Copy link

65.2

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 65.2 %
  • main branch coverage: 65.2 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@github-actions
Copy link

github-actions bot commented Oct 26, 2023

⌛ Starting datastoresrp functional tests...

⌛ Starting msgrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting shared functional tests...

@github-actions
Copy link

65.2

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 65.2 %
  • main branch coverage: 65.2 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@github-actions
Copy link

github-actions bot commented Oct 26, 2023

⌛ Starting daprrp functional tests...

⌛ Starting datastoresrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting kubernetes functional tests...

@github-actions
Copy link

⌛ Starting ucp functional tests...

@github-actions
Copy link

github-actions bot commented Oct 27, 2023

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref refs/pull/6587/merge
Unique ID 499ded3c08
Image tag pr-499ded3c08
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.11.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-499ded3c08
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-499ded3c08
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-499ded3c08
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-499ded3c08
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp functional tests...
⌛ Starting shared functional tests...
⌛ Starting datastoresrp functional tests...
✅ ucp functional tests succeeded
❌ datastoresrp functional test failed. Please check the logs for more details

@vinayada1
Copy link
Contributor Author

/ok-to-test

@github-actions
Copy link

github-actions bot commented Oct 27, 2023

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref 49df5b7
Unique ID 1193f735d1
Image tag pr-1193f735d1
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.11.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-1193f735d1
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-1193f735d1
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-1193f735d1
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-1193f735d1
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting shared functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting samples functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting datastoresrp functional tests...
✅ datastoresrp functional tests succeeded
✅ ucp functional tests succeeded
✅ msgrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ samples functional tests succeeded
✅ daprrp functional tests succeeded
❌ shared functional test failed. Please check the logs for more details

@github-actions
Copy link

github-actions bot commented Oct 27, 2023

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref refs/pull/6587/merge
Unique ID 4a5ec744c2
Image tag pr-4a5ec744c2
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.11.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-4a5ec744c2
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-4a5ec744c2
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-4a5ec744c2
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-4a5ec744c2
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting msgrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting samples functional tests...
❌ datastoresrp functional test failed. Please check the logs for more details

@github-actions
Copy link

65.2

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 65.2 %
  • main branch coverage: 65.2 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@github-actions
Copy link

github-actions bot commented Oct 27, 2023

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref refs/pull/6587/merge
Unique ID 39904da1ba
Image tag pr-39904da1ba
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.11.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-39904da1ba
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-39904da1ba
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-39904da1ba
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-39904da1ba
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp functional tests...
⌛ Starting samples functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting daprrp functional tests...
✅ datastoresrp functional tests succeeded
✅ msgrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ samples functional tests succeeded
✅ daprrp functional tests succeeded
✅ shared functional tests succeeded

@github-actions
Copy link

65.2

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 65.2 %
  • main branch coverage: 65.2 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@vinayada1
Copy link
Contributor Author

/ok-to-test

@vinayada1 vinayada1 changed the title Separate cloud/non-cloud tests [do not review] Separate cloud/non-cloud tests Oct 27, 2023
@github-actions
Copy link

github-actions bot commented Oct 27, 2023

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref 9597e44
Unique ID 1fbd59436d
Image tag pr-1fbd59436d
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.11.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-1fbd59436d
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-1fbd59436d
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-1fbd59436d
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-1fbd59436d
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting kubernetes functional tests...
⌛ Starting ucp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting samples functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting msgrp functional tests...
✅ datastoresrp functional tests succeeded
✅ ucp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ samples functional tests succeeded
✅ msgrp functional tests succeeded
✅ daprrp functional tests succeeded
❌ shared functional test failed. Please check the logs for more details
⌛ Starting shared functional tests...
✅ shared functional tests succeeded

@vinayada1
Copy link
Contributor Author

Looks like /ok-to-test still runs the old workflow and a PR merge would be needed for it to run only the cloud tests

Signed-off-by: vinayada1 <28875764+vinayada1@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Oct 27, 2023

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref refs/pull/6587/merge
Unique ID 902b2d1a89
Image tag pr-902b2d1a89
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.11.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-902b2d1a89
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-902b2d1a89
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-902b2d1a89
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-902b2d1a89
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting kubernetes functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting shared functional tests...
✅ datastoresrp functional tests succeeded
✅ ucp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ samples functional tests succeeded
✅ msgrp functional tests succeeded
✅ daprrp functional tests succeeded
✅ shared functional tests succeeded

@github-actions
Copy link

65.2

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 65.2 %
  • main branch coverage: 65.2 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@github-actions
Copy link

github-actions bot commented Oct 30, 2023

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref refs/pull/6587/merge
Unique ID 77855237db
Image tag pr-77855237db
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.11.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-77855237db
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-77855237db
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-77855237db
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-77855237db
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting daprrp functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting shared functional tests...
⌛ Starting ucp functional tests...
⌛ Starting samples functional tests...
✅ datastoresrp functional tests succeeded
✅ msgrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ samples functional tests succeeded
✅ shared functional tests succeeded

@github-actions
Copy link

65.1

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 65.1 %
  • main branch coverage: 65.1 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@vinayada1
Copy link
Contributor Author

/ok-to-test

@github-actions
Copy link

github-actions bot commented Oct 30, 2023

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref 63f6971
Unique ID e4cde3a90d
Image tag pr-e4cde3a90d
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.11.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-e4cde3a90d
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-e4cde3a90d
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-e4cde3a90d
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-e4cde3a90d
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting kubernetes functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting samples functional tests...
⌛ Starting ucp functional tests...
⌛ Starting daprrp functional tests...
✅ datastoresrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ ucp functional tests succeeded
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ daprrp functional tests succeeded
✅ shared functional tests succeeded

Copy link

github-actions bot commented Nov 3, 2023

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref refs/pull/6587/merge
Unique ID cf69d837d7
Image tag pr-cf69d837d7
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.11.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-cf69d837d7
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-cf69d837d7
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-cf69d837d7
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-cf69d837d7
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting daprrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting ucp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting datastoresrp functional tests...
✅ ucp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ daprrp functional tests succeeded
✅ samples functional tests succeeded
✅ shared functional tests succeeded
✅ kubernetes functional tests succeeded
✅ msgrp functional tests succeeded

Copy link

github-actions bot commented Nov 3, 2023

64.9

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 64.9 %
  • main branch coverage: 64.9 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

Copy link
Contributor

@kachawla kachawla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for kicking this off!

As I mentioned in the design discussion, from this PR it looks like all the UCP tests only run on cloud resources, in which case we should add more tests for UCP that can run as a part of functional tests workflow. Can you please confirm this?

@vinayada1
Copy link
Contributor Author

Thanks for kicking this off!

As I mentioned in the design discussion, from this PR it looks like all the UCP tests only run on cloud resources, in which case we should add more tests for UCP that can run as a part of functional tests workflow. Can you please confirm this?

I checked it. There are other UCP tests for testing planes/RGs, etc. Since there is no change, they already exist in the same folder, they do not show up in the changes
Screenshot 2023-11-07 at 4 41 04 PM

Copy link

github-actions bot commented Feb 8, 2024

This pull request has been automatically marked as stale because it has been inactive for 90 days. Remove stale label or comment or this PR will be closed in 7 days.

@github-actions github-actions bot added the stale label Feb 8, 2024
@github-actions github-actions bot closed this Feb 15, 2024
@youngbupark youngbupark deleted the tests-separate branch February 27, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate out functional tests that require cloud/external resources
3 participants