Separate out functional tests that require cloud/external resources #6588
Assignees
Labels
triaged
This issue has been reviewed and triaged
Comments
This was referenced Feb 29, 2024
vinayada1
added a commit
that referenced
this issue
Mar 1, 2024
# Description As a part of #6588, as proposed by radius-project/design-notes#35, we will use RequiredFeatures check to separate AWS and Azure specific tests. This is Part1 of a multi-part PR to change the organization of the tests ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request adds or changes features of Radius and has an approved issue (#6588 ). <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: A part of #6588 but multiple PRs to follow to fix completely --------- Signed-off-by: vinayada1 <28875764+vinayada1@users.noreply.github.com> Co-authored-by: Young Bu Park <youngp@microsoft.com>
This was referenced Mar 1, 2024
vinayada1
added a commit
that referenced
this issue
Mar 4, 2024
…ud tests (#7221) # Description - Separate cloud and non-cloud tests for messaging RP - Organize the UCP tests as per radius-project/design-notes#35. There will be more PRs that will follow to re-org the other tests. ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request adds or changes features of Radius and has an approved issue (#6588 ). <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: This is part of a multi-PR fix for #6588. Signed-off-by: vinayada1 <28875764+vinayada1@users.noreply.github.com>
willdavsmith
pushed a commit
to willdavsmith/radius
that referenced
this issue
Mar 4, 2024
# Description As a part of radius-project#6588, as proposed by radius-project/design-notes#35, we will use RequiredFeatures check to separate AWS and Azure specific tests. This is Part1 of a multi-part PR to change the organization of the tests ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request adds or changes features of Radius and has an approved issue (radius-project#6588 ). <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: A part of radius-project#6588 but multiple PRs to follow to fix completely --------- Signed-off-by: vinayada1 <28875764+vinayada1@users.noreply.github.com> Co-authored-by: Young Bu Park <youngp@microsoft.com>
vinayada1
added a commit
that referenced
this issue
Mar 4, 2024
# Description - Separate cloud/non-cloud tests - Organize the cli tests as per radius-project/design-notes#35. There will be more PRs that will follow to re-org the other tests. ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request adds or changes features of Radius and has an approved issue (#6588 ). <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: Fixes part of #6588. This is a part of a multi-PR fix Signed-off-by: vinayada1 <28875764+vinayada1@users.noreply.github.com>
vinayada1
added a commit
that referenced
this issue
Mar 5, 2024
# Description - Separate cloud/non-cloud tests - Organize the daprrp tests as per radius-project/design-notes#35. There will be more PRs that will follow to re-org the other tests. ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request adds or changes features of Radius and has an approved issue (#6588 ). <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: Fixes part of #6588. This is a part of a multi-PR fix --------- Signed-off-by: vinayada1 <28875764+vinayada1@users.noreply.github.com>
vinayada1
added a commit
that referenced
this issue
Mar 5, 2024
…non-cloud tests (#104) # Description - Separate cloud/non-cloud tests - Organize the UCP tests as per radius-project/design-notes#35. There will be more PRs that will follow to re-org the other tests. ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request adds or changes features of Radius and has an approved issue #6588 . <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: Fixes part of #6588. This is a part of a multi-PR fix --------- Signed-off-by: vinayada1 <28875764+vinayada1@users.noreply.github.com>
vinayada1
added a commit
that referenced
this issue
Mar 5, 2024
# Description - Separate cloud/non-cloud tests - Organize the daprrp tests as per radius-project/design-notes#35. There will be more PRs that will follow to re-org the other tests. ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request adds or changes features of Radius and has an approved issue (#6588). <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: Fixes part of #6588. This is a part of a multi-PR fix --------- Signed-off-by: vinayada1 <28875764+vinayada1@users.noreply.github.com>
vinayada1
added a commit
that referenced
this issue
Mar 5, 2024
# Description - Separate cloud/non-cloud tests - Organize the daprrp tests as per radius-project/design-notes#35. There will be more PRs that will follow to re-org the other tests. ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request adds or changes features of Radius and has an approved issue (#6588 ). <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: Fixes part of #6588. This is a part of a multi-PR fix --------- Signed-off-by: vinayada1 <28875764+vinayada1@users.noreply.github.com>
vinayada1
added a commit
that referenced
this issue
Mar 5, 2024
…7219) # Description - Separate cloud/non-cloud tests - Organize the UCP tests as per radius-project/design-notes#35. There will be more PRs that will follow to re-org the other tests. ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request adds or changes features of Radius and has an approved issue (#6588 ). <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: Fixes part of #6588. This is a part of a multi-PR fix --------- Signed-off-by: vinayada1 <28875764+vinayada1@users.noreply.github.com>
vinayada1
added a commit
that referenced
this issue
Mar 26, 2024
# Description - Change test organization for shared tests. These tests are now organized under the corerp directory. - Separate cloud/non-cloud tests - Organize the corerp tests as per radius-project/design-notes#35. There will be more PRs that will follow to re-org the other tests. ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request adds or changes features of Radius and has an approved issue (#6588 ). <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: Fixes part of #6588. This is a part of a multi-PR fix --------- Signed-off-by: vinayada1 <28875764+vinayada1@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Engineering Improvement
Area for Improvement (required)
Currently, all the functional tests run only with an approved "/ok-to-test" command. Only tests that deploy cloud resources or publish stuff really require an approval. This PR separates out the tests that do not need an approval to run as a part of the regular build workflow. The /ok-to-test command will now run only tests that deploy cloud resources
Observed behavior (required)
A maintainer must issue an /ok-to-test command to run any functional test on the PR
Desired behavior (required)
/ok-to-test command should be required to run only those tests that require cloud resources
Proposed Fix (optional)
System information
rad Version (required)
0.26.3
Operating system (required)
macOS
Additional context
AB#9945
The text was updated successfully, but these errors were encountered: