Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change test organization for datastoresrp tests #7224

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Change test organization for datastoresrp tests #7224

merged 2 commits into from
Mar 5, 2024

Conversation

vinayada1
Copy link
Contributor

Description

Type of change

Fixes: Fixes part of #6588. This is a part of a multi-PR fix

@vinayada1 vinayada1 requested review from a team as code owners March 1, 2024 21:57
@radius-functional-tests
Copy link

radius-functional-tests bot commented Mar 1, 2024 •
edited

Radius functional test overview

🔍 Go to test action run

Name Value
Repository test-org-admin/radius-main
Commit ref 15cb17d
Unique ID 9b8f28b4a7
Image tag pr-9b8f28b4a7
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-9b8f28b4a7
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-9b8f28b4a7
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-9b8f28b4a7
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-9b8f28b4a7
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting kubernetes functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting samples functional tests...
⌛ Starting datastoresrp functional tests...
✅ msgrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ samples functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

rynowak
rynowak reviewed Mar 3, 2024
View reviewed changes
build/test.mk Outdated
@@ -75,8 +75,13 @@ test-functional-msgrp: ## Runs Messaging RP functional tests
test-functional-daprrp: ## Runs Dapr RP functional tests
CGO_ENABLED=1 $(GOTEST_TOOL) ./test/functional/daprrp/... -timeout ${TEST_TIMEOUT} -v -parallel 3 $(GOTEST_OPTS)

test-functional-datastoresrp: ## Runs Datastores RP functional tests
CGO_ENABLED=1 $(GOTEST_TOOL) ./test/functional/datastoresrp/... -timeout ${TEST_TIMEOUT} -v -parallel 3 $(GOTEST_OPTS)
test-functional-datastoresrp: test-functional-datastoresrp-noncloud test-functional-datastoresrp-cloud ## Runs Datastores RP functional tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😻

rynowak
rynowak reviewed Mar 3, 2024
View reviewed changes
test/functional-portable/datastoresrp/cloud/resources/microsoftsql_test.go
@@ -75,5 +75,6 @@ func Test_MicrosoftSQL_Manual(t *testing.T) {
},
})

test.RequiredFeatures = []shared.RequiredFeature{shared.FeatureAzure}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

rynowak
rynowak previously approved these changes Mar 3, 2024
View reviewed changes
@vinayada1
Change test organization for datastoresrp tests
3fc9eda 
Signed-off-by: vinayada1 <28875764+vinayada1@users.noreply.github.com>
@vinayada1
fix comments
d6e22b9 
Signed-off-by: vinayada1 <28875764+vinayada1@users.noreply.github.com>
@radius-functional-tests
Copy link

radius-functional-tests bot commented Mar 5, 2024 •
edited

Radius functional test overview

🔍 Go to test action run

Name Value
Repository test-org-admin/radius-main
Commit ref d6e22b9
Unique ID d2abf7bf06
Image tag pr-d2abf7bf06
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-d2abf7bf06
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-d2abf7bf06
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-d2abf7bf06
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-d2abf7bf06
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting ucp functional tests...
✅ msgrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ samples functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

@vinayada1 vinayada1 merged commit 389526f into radius-project:main Mar 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ytimocin ytimocin ytimocin approved these changes

@rynowak rynowak rynowak left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vinayada1 @rynowak @ytimocin