Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kubebuilder to the latest working version #7629

Merged
merged 1 commit into from
May 23, 2024
Merged

Update kubebuilder to the latest working version #7629

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/test.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ test: test-get-envtools ## Runs unit tests, excluding kubernetes controller test
.PHONY: test-get-envtools
test-get-envtools:
@echo "$(ARROW) Installing Kubebuilder test tools..."
$(call go-install-tool,$(ENV_SETUP),sigs.k8s.io/controller-runtime/tools/setup-envtest@latest)
$(call go-install-tool,$(ENV_SETUP),sigs.k8s.io/controller-runtime/tools/setup-envtest@v0.0.0-20240521074430-fbb7d370bebc)
Copy link
Contributor

@rynowak rynowak May 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create an issue for the following (if you didn't already):

We should either:

  • Revert this in the future and use latest when they fix the issue.
  • Move this into a place where depdendabot can manage it for us.

We don't want this to be hardcoded forever.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, just opened a bug here: #7630. I also opened one in the controller-runtime repo that I'll monitor for responses: kubernetes-sigs/controller-runtime#2838

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like #7630 is tracking the build-break. We should also have a plan to remove the workaround.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered them parts of the same problem but I updated the issue to explicitly call out removing the workaround

@echo "$(ARROW) Instructions:"
@echo "$(ARROW) Set environment variable KUBEBUILDER_ASSETS for tests."
@echo "$(ARROW) KUBEBUILDER_ASSETS=\"$(shell $(ENV_SETUP) use -p path ${K8S_VERSION} --arch amd64)\""
Expand Down
Loading