Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kubebuilder to the latest working version #7629

Merged
merged 1 commit into from
May 23, 2024
Merged

Update kubebuilder to the latest working version #7629

merged 1 commit into from
May 23, 2024

Conversation

sk593
Copy link
Contributor

@sk593 sk593 commented May 22, 2024

Description

We have a dependency on the controller-runtime package that is failing during our build tests. Reverting the package to the last known working version instead of latest.

Package: https://github.com/kubernetes-sigs/controller-runtime
Error:

/bin/sh: 1: /home/runner/go/bin/setup-envtest: not found
=> Installing Kubebuilder test tools...
go: downloading sigs.k8s.io/controller-runtime/tools/setup-envtest v0.0.0-20240522175850-2e9781e9fc60
go: downloading github.com/spf13/afero v1.6.0
go: downloading go.uber.org/zap v1.26.0
go: downloading sigs.k8s.io/yaml v1.3.0
go: downloading golang.org/x/text v0.14.0
go: downloading go.uber.org/multierr v1.10.0
=> Instructions:
=> Set environment variable KUBEBUILDER_ASSETS for tests.
=> KUBEBUILDER_ASSETS=""
unable to find a version that was supported for platform linux/amd64
KUBEBUILDER_ASSETS="" CGO_ENABLED=1 gotestsum --junitfile ./dist/unit_test/results.xml -- -v ./pkg/... -race -coverprofile ./dist/unit_test/ut_coverage.out

Type of change

  • This pull request fixes a bug in Radius and has an approved issue (issue link required).
  • This pull request adds or changes features of Radius and has an approved issue (issue link required).
  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

@sk593
update kubebuilder version
2e05ece 
Signed-off-by: sk593 <shruthikumar@microsoft.com>
@sk593 sk593 requested review from a team as code owners May 22, 2024 23:15
@sk593 sk593 temporarily deployed to functional-tests May 22, 2024 23:15 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

Unit Tests

3 194 tests  +56   3 188 ✅ +69   3m 59s ⏱️ + 1m 30s
  259 suites ± 0       6 💤  - 11 
    1 files   ± 0       0 ❌  -  2 

Results for commit 2e05ece. ± Comparison against base commit 66aad2c.

@codecov Codecov
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.05%. Comparing base (ea316f3) to head (2e05ece).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7629      +/-   ##
==========================================
+ Coverage   61.00%   61.05%   +0.04%     
==========================================
  Files         517      517              
  Lines       26514    26556      +42     
==========================================
+ Hits        16176    16214      +38     
- Misses       8916     8918       +2     
- Partials     1422     1424       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@radius-functional-tests
Copy link

radius-functional-tests bot commented May 22, 2024 •
edited

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref 2e05ece
Unique ID funcc646bbba10
Image tag pr-funcc646bbba10
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcc646bbba10
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcc646bbba10
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funcc646bbba10
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcc646bbba10
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting samples functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting datastoresrp functional tests...
✅ samples functional tests succeeded
✅ msgrp functional tests succeeded
✅ ucp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ daprrp functional tests succeeded
✅ cli functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

rynowak
rynowak reviewed May 22, 2024
View reviewed changes
build/test.mk
@@ -49,7 +49,7 @@ test: test-get-envtools ## Runs unit tests, excluding kubernetes controller test
.PHONY: test-get-envtools
test-get-envtools:
@echo "$(ARROW) Installing Kubebuilder test tools..."
$(call go-install-tool,$(ENV_SETUP),sigs.k8s.io/controller-runtime/tools/setup-envtest@latest)
$(call go-install-tool,$(ENV_SETUP),sigs.k8s.io/controller-runtime/tools/setup-envtest@v0.0.0-20240521074430-fbb7d370bebc)
Copy link
Contributor

@rynowak rynowak May 22, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create an issue for the following (if you didn't already):

We should either:

  • Revert this in the future and use latest when they fix the issue.
  • Move this into a place where depdendabot can manage it for us.

We don't want this to be hardcoded forever.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, just opened a bug here: #7630. I also opened one in the controller-runtime repo that I'll monitor for responses: kubernetes-sigs/controller-runtime#2838

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like #7630 is tracking the build-break. We should also have a plan to remove the workaround.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered them parts of the same problem but I updated the issue to explicitly call out removing the workaround

rynowak
rynowak approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@rynowak rynowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sk593 sk593 merged commit 4cacb58 into main May 23, 2024
19 checks passed
@sk593 sk593 deleted the update-kubebuilder branch May 23, 2024 00:18
sk593 added a commit that referenced this pull request May 23, 2024
@sk593
Revert "Update kubebuilder to the latest working version (#7629)"
d72d107 
This reverts commit 4cacb58.
@sk593 sk593 mentioned this pull request May 23, 2024
Merged
sk593 added a commit that referenced this pull request May 23, 2024
@sk593
Revert "Update kubebuilder to the latest working version (#7629)"
7929cf6 
This reverts commit 4cacb58.

Signed-off-by: sk593 <shruthikumar@microsoft.com>
ytimocin pushed a commit that referenced this pull request May 25, 2024
@sk593 @ytimocin
Revert "Update kubebuilder to the latest working version (#7629)"
800e4c9 
This reverts commit 4cacb58.

Signed-off-by: sk593 <shruthikumar@microsoft.com>
sk593 added a commit that referenced this pull request May 28, 2024
@sk593
Revert "Update kubebuilder to the latest working version (#7629)"
217f645 
This reverts commit 4cacb58.

Signed-off-by: sk593 <shruthikumar@microsoft.com>
sk593 added a commit that referenced this pull request May 28, 2024
@sk593
Revert "Update kubebuilder to the latest working version" (#7632)
2b2b9d9 
Reverts #7629

This was fixed as per the convo in
kubernetes-sigs/controller-runtime#2838. It
looks like the binaries weren't released for the version of Kubernetes
that we were using (they had up until 1.24 but we were using 1.23)

Fixes: #7630

---------

Signed-off-by: sk593 <shruthikumar@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rynowak rynowak rynowak approved these changes

@kachawla kachawla kachawla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sk593 @rynowak @kachawla