Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve purge workflow failure logging by upgrading to snok/container-retention v 3.0.0 #7835

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

nithyatsu
Copy link
Contributor

@nithyatsu nithyatsu commented Aug 23, 2024

Description

updating to latest version of snok/container-retention seems to help with failures.
ref: https://github.com/radius-project/radius/actions/runs/10532606785/job/29187086343
(check only delete unused container images, since it is a workflow_dispatch)

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

Copy link

github-actions bot commented Aug 23, 2024

Unit Tests

3 299 tests  ±0   3 293 ✅ ±0   3m 57s ⏱️ ±0s
  263 suites ±0       6 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 5d82f27. ± Comparison against base commit 7da87d4.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.07%. Comparing base (7da87d4) to head (5d82f27).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7835      +/-   ##
==========================================
+ Coverage   61.05%   61.07%   +0.02%     
==========================================
  Files         523      523              
  Lines       27466    27466              
==========================================
+ Hits        16768    16774       +6     
+ Misses       9212     9209       -3     
+ Partials     1486     1483       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: nithyatsu <nithyasu@microsoft.com>
Signed-off-by: nithyatsu <nithyasu@microsoft.com>
Signed-off-by: nithyatsu <nithyasu@microsoft.com>
Signed-off-by: nithyatsu <nithyasu@microsoft.com>
Signed-off-by: nithyatsu <nithyasu@microsoft.com>
Signed-off-by: nithyatsu <nithyasu@microsoft.com>
Signed-off-by: nithyatsu <nithyasu@microsoft.com>
Signed-off-by: nithyatsu <nithyasu@microsoft.com>
Signed-off-by: nithyatsu <nithyasu@microsoft.com>
Signed-off-by: nithyatsu <nithyasu@microsoft.com>
Signed-off-by: nithyatsu <nithyasu@microsoft.com>
Signed-off-by: nithyatsu <nithyasu@microsoft.com>
Signed-off-by: nithyatsu <nithyasu@microsoft.com>
Signed-off-by: nithyatsu <nithyasu@microsoft.com>
@radius-functional-tests
Copy link

radius-functional-tests bot commented Aug 23, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref 90d5281
Unique ID func7aa94ab24e
Image tag pr-func7aa94ab24e
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func7aa94ab24e
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func7aa94ab24e
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func7aa94ab24e
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func7aa94ab24e
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ datastoresrp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded

@radius-functional-tests
Copy link

radius-functional-tests bot commented Aug 23, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref 5d82f27
Unique ID func0aa4cdc77f
Image tag pr-func0aa4cdc77f
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func0aa4cdc77f
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func0aa4cdc77f
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func0aa4cdc77f
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func0aa4cdc77f
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting datastoresrp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ datastoresrp-cloud functional tests succeeded
❌ Test tool installation for ucp-cloud failed. Please check the logs for more details
❌ Failed to install Radius for ucp-cloud functional test. Please check the logs for more details
❌ ucp-cloud functional test failed. Please check the logs for more details
❌ Test tool installation for corerp-cloud failed. Please check the logs for more details
❌ Failed to install Radius for corerp-cloud functional test. Please check the logs for more details
❌ corerp-cloud functional test failed. Please check the logs for more details

@nithyatsu nithyatsu changed the title debugging purge failure fix purge workflow failures Aug 23, 2024
@nithyatsu nithyatsu changed the title fix purge workflow failures fix purge workflow failures by upgrading to snok/container-retention v 3.0.0 Aug 23, 2024
- name: Delete 'dev' containers older than a week
uses: snok/container-retention-policy@v2
- name: Delete 'dev' containers older 3 days
uses: snok/container-retention-policy@v3.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v3 should be enough or do we want to fix it to a specific version (v3.0.0)?

@nithyatsu nithyatsu changed the title fix purge workflow failures by upgrading to snok/container-retention v 3.0.0 improve purge workflow failure logging by upgrading to snok/container-retention v 3.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants