[Tooltip] Improve state machine separation of concerns #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 11, 2021
jjenzz
approved these changes
Mar 18, 2021
| ); | ||
| } | ||
| } else { | ||
| PREVIOUS_STATE = CURRENT_STATE; |
There was a problem hiding this comment.
I know you haven't changed this but it really confused me seeing uppercase variables being reassigned like this. I would usually expect all uppercase to be a constant.
There was a problem hiding this comment.
Good point. Is it ok with you if I make this change once we've merged the stack of PRs to make conflict handling easier?
benoitgrelard
added a commit
that referenced
this pull request
Mar 22, 2021
# New features Breaking changes are indicated with a 🔥 icon. [Tooltip] Add custom duration support (#550, #551, #554, #558) [Tooltip] Add unmount animation support (#558) [Toggle] Rename `ToggleButton` primitive to `Toggle` and `toggled` to `pressed` (#546) 🔥 [ToggleGroup] New primitive! (#376) 🎉 # Fixes [ContextMenu] Ensure you can open a context menu when one is already open (#565) [Popper] Fix potential issues with non-measured positioning (#541) [Presence] Fix unmount hanging (#548)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, it mostly looks like completely new code now because I moved stuff into 2 separate files 😢
I was finding it hard to follow before, so now we have one file for the state machine implementation and one for the actual tooltip statechart.
xstatecloser (I hadcamelCasevs.UPPER_CASEthe wrong way around for state vs. events)xstatesendfrom entry/exit actions, which apparently is not really correct looking atxstate