[Tooltip] Add unmount animation support #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitgrelard
commented
Mar 15, 2021
| @@ -81,6 +82,8 @@ const Tooltip: React.FC<TooltipOwnProps> = (props) => { | |||
| } else if (state === 'closed') { | |||
| setStateAttribute('closed'); | |||
| } | |||
| } else { | |||
| setStateAttribute('closed'); | |||
There was a problem hiding this comment.
The key fix here was this to ensure only one tooltip remain open at once because we had an issue where the state attribute was the same on all instances.
I thought I had fixed it in previous PRs by adding the check for the tooltip id, but we also want to make sure if it's not this particular tooltip, it should be considered closed.
benoitgrelard
force-pushed
the
tooltip-timings-2
branch
from
c12f873
to
aa67e63
Compare
benoitgrelard
force-pushed
the
tooltip-presence
branch
from
c1ba72c
to
f56efb4
Compare
benoitgrelard
commented
Mar 19, 2021
| @@ -100,9 +101,11 @@ const Tooltip: React.FC<TooltipOwnProps> = (props) => { | |||
| if (context.id === contentId) { | |||
| if (state === 'open') { | |||
| setStateAttribute(context.delayed ? 'delayed-open' : 'instant-open'); | |||
| } else if (state === 'closed') { | |||
| } else { | |||
There was a problem hiding this comment.
Removed this explicit check, that's what was breaking the unmount animation. It was there because that PR was based on having only open and closed state, but now that we have more it should go (wasn't needed anyway).
jjenzz
approved these changes
Mar 19, 2021
benoitgrelard
added a commit
that referenced
this pull request
Mar 22, 2021
# New features Breaking changes are indicated with a 🔥 icon. [Tooltip] Add custom duration support (#550, #551, #554, #558) [Tooltip] Add unmount animation support (#558) [Toggle] Rename `ToggleButton` primitive to `Toggle` and `toggled` to `pressed` (#546) 🔥 [ToggleGroup] New primitive! (#376) 🎉 # Fixes [ContextMenu] Ensure you can open a context menu when one is already open (#565) [Popper] Fix potential issues with non-measured positioning (#541) [Presence] Fix unmount hanging (#548)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mainonce [Tooltip] Improve on custom durations + fixes #554 is merged.I'll add versions file after the above is merged ☝️
Closes #459