fix(Calendar): sometimes first day of next month is missing #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great catch @xollaborator! Thank you for your contribution!👍🏻 This functionality and the date utilities are ported from Melt UI, therefore this fix would help them too. Here's the corresponding line in Melt UI: https://github.com/melt-ui/melt-ui/blob/42e2dd430c3e13f56062c4d610dabd84ea4e5517/src/lib/internal/helpers/date/calendar.ts#L97 |
epr3
approved these changes
Jun 23, 2024
xollaborator
commented
Jun 23, 2024
Sure, I might try to help them, especially that there is already bug for this issue: melt-ui/melt-ui#1213. |
xollaborator
deleted the
fix/calendar-sometimes-first-day-of-next-month-is-missing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fixedWeeks is true and next month starts in another row of Calendar first day was missing:
After the fix:
Fix is quite simple but I've also extended the test case and added a new story for fixedWeeks.
I do not know if you want to have all fixes covered by a test case but taking in to account that on my machine Calendar tests took 15 seconds before and now 2 seconds were added I would personally not merge my test.
I think the new story is also not providing that much value but it helped me test the fix so I included it as well.
Thank you for this library and for shadcn/vue :)