Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid failing resolve types by adding radix-vue to project deps in shadcn-vue init before the add command #216

Merged
merged 6 commits into from
Dec 21, 2023

Conversation

sadeghbarati
Copy link
Collaborator

resolve: #207

shadcn-vue init will add tailwind-related dependencies

And if the user wants to use shadcn-vue components without TypeScript they will face this error
[@vue/compiler-sfc] Failed to resolve extends base type

cause detypes can't resolve the types when radix-vue is not yet present in dependencies

Copy link
Member

@zernonia zernonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for drilling through the issue @sadeghbarati ! I believe this would solve the issue pretty well.. I believe radix-vue should be in the base_deps.

@sadeghbarati
Copy link
Collaborator Author

Should we remove radix-vue keyword from

Components Registry index.json?

@zernonia
Copy link
Member

I think we can do that. then rebuild registry without radix-vue as dep for component as it would already be installed by then.

@sadeghbarati sadeghbarati force-pushed the fix/issue/207 branch 2 times, most recently from c8e1500 to 993c68e Compare December 20, 2023 19:08
@sadeghbarati
Copy link
Collaborator Author

@zernonia Done! can you build the registry on your side output is different, if I build it on Windows OS - related #181

@zernonia zernonia merged commit 010e377 into radix-vue:dev Dec 21, 2023
0 of 2 checks passed
@sadeghbarati sadeghbarati deleted the fix/issue/207 branch December 21, 2023 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: [@vue/compiler-sfc] Failed to resolve extends base type. While adding button component
2 participants