Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the broken navigation links for the code examples under the "Form" tab #553

Merged
merged 1 commit into from
May 23, 2024

Conversation

JiuRanYa
Copy link
Contributor

Go https://www.shadcn-vue.com/examples/forms/account.html and click Views code, then got incorrect href.

@sadeghbarati
Copy link
Collaborator

404 Page Not Found

image

Thanks for PR,
The route seems confusing but I think Vitepress configured this way

https://github.com/radix-vue/shadcn-vue/blob/dev/apps/www/.vitepress/config.mts#L67C3-L69C5

@JiuRanYa
Copy link
Contributor Author

JiuRanYa commented May 16, 2024

404 Page Not Found
image

Thanks for PR, The route seems confusing but I think Vitepress configured this way

https://github.com/radix-vue/shadcn-vue/blob/dev/apps/www/.vitepress/config.mts#L67C3-L69C5

Hey, ,maybe when you go forms/account or sub route, you will redirect the form's href and get the correct demo code, not go /form directly

const currentExample = computed(() => examples.find(ex => path.value.startsWith(ex.href)) ?? examples[0])

@JiuRanYa
Copy link
Contributor Author

JiuRanYa commented May 16, 2024

If there has some better ways, pls fix the href. Thanks!

@sadeghbarati sadeghbarati reopened this May 23, 2024
@JiuRanYa JiuRanYa changed the title fix: forms views code href fix: the broken navigation links for the code examples under the "Form" tab May 23, 2024
@zernonia zernonia linked an issue May 23, 2024 that may be closed by this pull request
2 tasks
Copy link
Member

@zernonia zernonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution LGTM! At least it navigate to the correct repo link now 😁

@zernonia zernonia merged commit 63bb218 into radix-vue:dev May 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs]: the broken navigation links for the code examples under the "Form" tab
3 participants