Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update moka version #1327

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Update moka version #1327

merged 1 commit into from
Aug 14, 2023

Conversation

talekhinezh
Copy link
Member

Summary

The current version of moka (0.9.4) has a bug (moka-rs/moka#272). Updated to version 0.9.9 which fixed bug.

@talekhinezh talekhinezh marked this pull request as ready for review August 11, 2023 22:44
@github-actions
Copy link

Benchmark for b9ba89e

Click to view benchmark
Test Base PR %
costing::bench_prepare_wasm 105.6±2.49ms 103.7±0.36ms -1.80%
costing::decode_sbor 29.5±0.55µs 29.8±0.76µs +1.02%
costing::deserialize_wasm 1913.8±32.81µs 1919.5±13.37µs +0.30%
costing::instantiate_flash_loan 6.5±0.05ms 6.6±0.11ms +1.54%
costing::instantiate_radiswap 6.3±0.45ms 5.2±0.61ms -17.46%
costing::spin_loop 11.8±0.10ms 11.5±0.19ms -2.54%
costing::validate_sbor_payload 41.0±1.12µs 40.8±0.71µs -0.49%
costing::validate_secp256k1 102.9±3.35µs 101.7±1.21µs -1.17%
costing::validate_wasm 45.8±0.63ms 46.0±0.37ms +0.44%
decimal::add/0 1.2±0.00ns 1.2±0.04ns 0.00%
decimal::div/0 275.8±0.96ns 279.6±3.53ns +1.38%
decimal::from_string/0 300.3±1.88ns 325.9±43.88ns +8.52%
decimal::mul/0 247.9±1.17ns 242.7±4.79ns -2.10%
decimal::pow/0 1185.6±6.30ns 1234.9±70.72ns +4.16%
decimal::root/0 15.0±0.06µs 14.8±0.22µs -1.33%
decimal::sub/0 1.2±0.00ns 1.2±0.04ns 0.00%
decimal::to_string/0 1202.6±7.10ns 1206.8±43.99ns +0.35%
precise_decimal::add/0 9.2±0.11ns 9.3±0.31ns +1.09%
precise_decimal::div/0 929.7±8.94ns 953.8±56.05ns +2.59%
precise_decimal::from_string/0 810.6±30.39ns 812.1±22.61ns +0.19%
precise_decimal::mul/0 945.5±3.39ns 952.6±19.62ns +0.75%
precise_decimal::pow/0 4.7±0.01µs 4.8±0.15µs +2.13%
precise_decimal::root/0 111.8±0.79µs 112.4±0.46µs +0.54%
precise_decimal::sub/0 9.0±0.22ns 9.0±0.25ns 0.00%
precise_decimal::to_string/0 2.7±0.03µs 2.7±0.03µs 0.00%
schema::validate_payload 415.4±6.18µs 433.7±24.92µs +4.41%
transaction::radiswap 6.2±0.10ms 6.2±0.17ms 0.00%
transaction::transfer 2.1±0.06ms 2.1±0.01ms 0.00%
transaction_processing::prepare 3.3±0.07ms 3.3±0.01ms 0.00%
transaction_processing::prepare_and_decompile 9.4±0.19ms 9.5±0.17ms +1.06%
transaction_processing::prepare_and_decompile_and_recompile 30.7±0.12ms 29.9±0.30ms -2.61%
transaction_validation::validate_manifest 56.4±2.35µs 56.0±0.86µs -0.71%
transaction_validation::verify_ecdsa 98.0±0.37µs 98.1±0.21µs +0.10%
transaction_validation::verify_ed25519 67.8±2.69µs 66.8±0.09µs -1.47%

@iamyulong iamyulong merged commit 0118653 into develop Aug 14, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants