Add BLS signatures #1661
Merged
Add BLS signatures #1661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrubasze
force-pushed
the
feature/bls_signatures
branch
from
1de4826
to
b0dc5e1
Compare
Benchmark for ce7c01fClick to view benchmark
|
talekhinezh
reviewed
Dec 5, 2023
iamyulong
reviewed
Dec 6, 2023
| @@ -379,10 +379,15 @@ create_well_known_lookup!( | |||
| MISC_TYPES_START + 7, | |||
There was a problem hiding this comment.
Chang well-known types is a protocol change. Will need to be synchronised with a specific protocol update.
There was a problem hiding this comment.
AFAIK, well-known types change is not necessary, so theoretically we could skip it. But since we require the protocol update anyway I would leave it as is.
iamyulong
approved these changes
Dec 7, 2023
Hashes, keys, signing, verification moved to 'radix-engine-common'. In 'transaction' above primitives are wrapped with RE specifics such as: - IntentSignature, - NotarySignature - etc.
ATM it is not required in WASM in Scrypto. Partial support (BLS verification, Keccak hash) is implemented natively via Client API.
This is to make sure public key count matches message count. Take vector of tuples (public key and message) as argument.
Do not take aggregation into account. Just sum up the costs per size for all messages.
It does not work for WASM and no_std
Add BLS aggregation features to `CryptoUtils` module
talekhinezh
force-pushed
the
feature/bls_signatures
branch
from
b1bf2a6
to
cea6713
Compare
…-crypto-utils Feature: Add protocol update for crypto utils
talekhinezh
reviewed
Jan 12, 2024
| HASH, | ||
| MISC_TYPES_START + 8, | ||
| named_transparent("Hash", bytes_fixed_length_type_data(Hash::LENGTH),) | ||
| ), |
There was a problem hiding this comment.
Can we remove this? As this is still a protocol change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for:
It also implements
CryptoUtilsmodule for Client API, which allows to do some crypto-related stuff natively from Scrypto.CryptoUtilsfunctions:keccak_hash()- generate Keccak-256 hash of the given messagebls_verify()- do the given BLS signature verification of the given message hash using given public keyDetails
BLS details:
In order to get it working I had to move cryptographic primitives (PrivateKey, Signature definitions) from
transactiontoradix-engine-common. What is left intransactionare the Radix Engine cryptographics, eg.IntentSignatureV1,NotarySignatureV1.Cryptographic dependencies in
radix-engine-commonare not built for WASM.Reasons:
blst) or their deps (eg.secp256k1-sys) are not implemented in Rust. Andclangused in macOS GH runner does not support WASM target. For now we skip it (maybe eventually we would need the WASM support there anyway)TODO: Costing
Testing
CryptoUtilsmodule usingCryptoScryptotest blueprint