Add BLS aggregation features to CryptoUtils module
#1666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrubasze
commented
Dec 21, 2023
Benchmark for 44b06feClick to view benchmark
|
0xOmarA
reviewed
Jan 8, 2024
| } | ||
|
|
||
| #[trace_resources(log=signatures.len())] | ||
| fn bls12381_g2_signature_aggregate( |
There was a problem hiding this comment.
I see that we can also aggregate public keys, is this something that we should add? Would any of the integrators we know of have a use for it?
There was a problem hiding this comment.
According to Supra, they will need only the basic BLS functionality introduced here: #1661
When researching the BLS I found that signature aggregation is more of a use in terms of Oracles.
eg.
https://www.researchgate.net/publication/350462947_Trusted_Blockchain_Oracle_Scheme_Based_on_Aggregate_Signature
0xOmarA
reviewed
Jan 8, 2024
0xOmarA
approved these changes
Jan 10, 2024
lrubasze
force-pushed
the
feature/bls_signatures
branch
from
e5650ff
to
69d1642
Compare
This is to make sure public key count matches message count. Take vector of tuples (public key and message) as argument.
Do not take aggregation into account. Just sum up the costs per size for all messages.
lrubasze
force-pushed
the
feature/crypto_utils_aggregate
branch
from
34ee3d8
to
3d404ce
Compare
It does not work for WASM and no_std
lrubasze
force-pushed
the
feature/crypto_utils_aggregate
branch
from
3d404ce
to
eca021b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds following API methods to
CryptoUtils:bls12381_g2_signature_aggregate()Aggregate given BLS12-381 G2 signatures into single one
bls12381_v1_aggregate_verify()Perform BLS12-381 G2 aggregated signature verification of multiple messages, where each is signed with different key
bls12381_v1_fast_aggregate_verify()Performs BLS12-381 G2 aggregated signature verification of single message signed with different keys
Details
Proposed API was inspired by:
blstcrate APITODO: Costing
Testing
bls12381(inradix-engine-common) module implementationCryptoUtilsmodule usingCryptoScryptotest blueprint